[preview4] Fix SuppressTrimAnalysisWarnings#17051
Merged
sbomer merged 2 commits intodotnet:release/6.0.1xx-preview4from Apr 21, 2021
Merged
[preview4] Fix SuppressTrimAnalysisWarnings#17051sbomer merged 2 commits intodotnet:release/6.0.1xx-preview4from
sbomer merged 2 commits intodotnet:release/6.0.1xx-preview4from
Conversation
This needs to be set before the .NET SDK targets get imported, otherwise the .NET defaults win.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
agocke
reviewed
Apr 21, 2021
| publishCommand.Execute().Should().Pass() | ||
| .And.NotHaveStdOutContaining("warning IL"); | ||
|
|
||
| var publishDirectory = publishCommand.GetOutputDirectory(DefaultTfm); |
Member
Author
There was a problem hiding this comment.
Should be net6. It comes from
Line 11 in e50d5ae
which gets set as metadata on the test assembly in
and this is picked up in the test infra:
FWIW I did check that the test produces warnings if I set SuppressTrimAnalysisWarnings=false and this causes it to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting #17050 to preview4.