[API Compat] Add rule to validate members are not added to interfaces#18834
Merged
safern merged 2 commits intodotnet:mainfrom Jul 9, 2021
Merged
[API Compat] Add rule to validate members are not added to interfaces#18834safern merged 2 commits intodotnet:mainfrom
safern merged 2 commits intodotnet:mainfrom
Conversation
Anipik
reviewed
Jul 9, 2021
Anipik
reviewed
Jul 9, 2021
Anipik
reviewed
Jul 9, 2021
Anipik
approved these changes
Jul 9, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #17928
I decided to not add a flag to specify if default implementations should be breaking as those can only appear on a runtime that supports them. If the target runtime that the code is being compiled for doesn't support that when adding a default implementation the compiler will error.
FYI: @terrajobst @utpilla