Skip to content

[Release/6.0.1xx-rc1] Dispose Open handle on the produced package#20156

Merged
Anipik merged 1 commit intodotnet:release/6.0.1xx-rc1from
Anipik:disposeHandle
Aug 26, 2021
Merged

[Release/6.0.1xx-rc1] Dispose Open handle on the produced package#20156
Anipik merged 1 commit intodotnet:release/6.0.1xx-rc1from
Anipik:disposeHandle

Conversation

@Anipik
Copy link
Copy Markdown
Contributor

@Anipik Anipik commented Aug 25, 2021

Description

Package validation task uses nuget apis to load the package in memory
We were not disposing one of the handles to the nuget package. This opened handle didnt allow the users to do any operations on packages even after the pack task has been completed.

In this change we add the using statement to dispose off the handle after the loading the package in memory.

Customer Impact

Some customers might start getting file contention issues when they are moving or editing the nuget packages. we hit this while enabling the package validation feature in dotnet/aspnetcore

Regression?

  • Yes
  • No

Risk

  • Low

This whole feature is an opt-in feature.

Verification

  • Ran a build of dotnet/aspnetcore with the change and verified that the build is successful with this change. Aspnetcore edits the packages after the pack task

@Anipik Anipik changed the title [Release/6.0.1xx-rc1]Dispose Open handle on the package [Release/6.0.1xx-rc1] Dispose Open handle on the package Aug 26, 2021
@Anipik Anipik changed the title [Release/6.0.1xx-rc1] Dispose Open handle on the package [Release/6.0.1xx-rc1] Dispose Open handle on the produced package Aug 26, 2021
@Anipik Anipik merged commit c53efa4 into dotnet:release/6.0.1xx-rc1 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants