[Release/6.0.1xx-rc1] Dispose Open handle on the produced package#20156
Merged
Anipik merged 1 commit intodotnet:release/6.0.1xx-rc1from Aug 26, 2021
Anipik:disposeHandle
Merged
[Release/6.0.1xx-rc1] Dispose Open handle on the produced package#20156Anipik merged 1 commit intodotnet:release/6.0.1xx-rc1from Anipik:disposeHandle
Anipik merged 1 commit intodotnet:release/6.0.1xx-rc1from
Anipik:disposeHandle
Conversation
joperezr
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Package validation task uses nuget apis to load the package in memory
We were not disposing one of the handles to the nuget package. This opened handle didnt allow the users to do any operations on packages even after the pack task has been completed.
In this change we add the using statement to dispose off the handle after the loading the package in memory.
Customer Impact
Some customers might start getting file contention issues when they are moving or editing the nuget packages. we hit this while enabling the package validation feature in dotnet/aspnetcore
Regression?
Risk
This whole feature is an opt-in feature.
Verification