Add OS and Process Architecture#21517
Merged
Merged
Conversation
ghost
added
the
marcpopMSFT
force-pushed
the
marcpopMSFT-Architecture
branch
from
adeeaea to
43a0b4d
Compare
wli3
approved these changes
Oct 1, 2021
…D for this instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During our discussions around arm64 it became clear that we weren't sure how often customers use an SDK that doesn't match their current OS. Adding this will help us answer that question so we know whether to prioritize this or not.
Regression?
No
Risk
Low, no functional change.
For performance measurements, I ran
dotnet build --help100 times in a row with and without the change which triggers on telemetry call. I found it 109 seconds with the change and 108 seconds without for a slowdown of ~10ms potentially.Verification
[X] Manual (required)
[x] Automated