Skip to content

Fix paths in MSBuildAllProjects#2182

Merged
tmat merged 1 commit into
dotnet:release/2.1.3xx-srcfrom
tmat:FixBuildProps
Apr 25, 2018
Merged

Fix paths in MSBuildAllProjects#2182
tmat merged 1 commit into
dotnet:release/2.1.3xx-srcfrom
tmat:FixBuildProps

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Apr 25, 2018

No description provided.

@tmat tmat merged commit 765c4dc into dotnet:release/2.1.3xx-src Apr 25, 2018
@dsplaisted
Copy link
Copy Markdown
Member

@tmat What was the reason for this change? Shouldn't all .props and .targets add themselves to MSBuildAllProjects instead of some of them adding the path to the thing they're importing?

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Apr 25, 2018

Apparently not. @tannergooding explained here: #2178 (comment)

tmat added a commit that referenced this pull request Apr 26, 2018
* Update RepoToolset to 1.0.0-beta2-62804-01

* Update dotnet SDK to 2.1.300-preview3-008616 (#2180)

* Remove --log argument from build.sh

* Exclude test projects from source build (#2181)

* Fix paths in MSBuildAllProjects (#2182)
wli3 pushed a commit to wli3/sdk that referenced this pull request May 17, 2018
* Update RepoToolset to 1.0.0-beta2-62804-01

* Update dotnet SDK to 2.1.300-preview3-008616 (dotnet#2180)

* Remove --log argument from build.sh

* Exclude test projects from source build (dotnet#2181)

* Fix paths in MSBuildAllProjects (dotnet#2182)
@tmat tmat deleted the FixBuildProps branch November 20, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants