Putting back the 'perf' property switch#2273
Merged
Merged
Conversation
johnbeisner
changed the title
johnbeisner
changed the title
Contributor
|
Welcome to the dotnet/sdk Perf help The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following optional jobs are available in PRs against dotnet/sdk:release/2.1.3xx. Click to expand
Have a nice day! |
Contributor
Author
|
@dotnet-bot test Windows_NT x64 sdk perf tests |
Contributor
Author
|
@dotnet-bot test Windows_NT x86 sdk perf tests |
dsplaisted
approved these changes
May 24, 2018
tmat
approved these changes
May 24, 2018
livarcocc
approved these changes
May 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting back the 'perf' MSBuild property switch: "/p:PerformanceTest=$perf" which was erroneously removed from 'build.ps1' and 'build.sh' in a recent RepoToolset update: #2178. The performance CI legs will fail to run without it.