[WIP] Add warning for ref to netstandard >= 1.5 from netfx without built-in support#2316
[WIP] Add warning for ref to netstandard >= 1.5 from netfx without built-in support#2316nguerrera wants to merge 2 commits intodotnet:release/2.1.4xxfrom
Conversation
|
NOTE: Error code may still change as this will conflict with #2282 |
|
Another TODO item: suppression mechanism. It should work to do I think we should leverage this moving forward now that our errors have codes and stop adding individual booleans for everything. But this needs testing. The doc at the fwlink should cover how to suppress if things are working fine for you and you haven't been impacted by the known issues. |
| </data> | ||
| </root> | ||
| <data name="NETFrameworkToNonBuiltInNETStandard" xml:space="preserve"> | ||
| <value>NETSDK1066: You’re using a .NET Standard 1.5 or higher library but targeting a .NET Framework without built-in support. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.</value> |
There was a problem hiding this comment.
Suggest:
This project uses a library that targets .NET Standard 1.5 or higher and targets a version of .NET Framework that does not have built-in support for that version of .NET Standard. Visit https://go.microsoft.com/fwlink/?linkid=874511 for a set of known issues. Consider retargeting to .NET Framework 4.7.2.
I'd also suggest creating an aka.ms link instead of a fwlink, that way we can choose a name that's easier to type in, for example http://aka.ms/net-standard-known-issues.
@mairaw Can you review this for style?
There was a problem hiding this comment.
Your suggestion LGTM @dsplaisted! Only nit per Microsoft style guide is the use of contractions
does not -> doesn't
|
Continue at #2330 |
I'm handing this off to a teammate while I'm away.
Still TODO: