Revert "Add warning for ref to netstandard >= 1.5 from netfx without built-in support"#2390
Merged
nguerrera merged 1 commit intodotnet:release/2.1.4xxfrom Jul 10, 2018
Conversation
…built-in support" This reverts the code and test changes from commit 78b4b0b, but it keeps the warning message in .resx/.xlf as the warning will be reintroduced in a later version and we need to keep the warning code reserved for it.
Contributor
Author
|
We are going to wait until .NET Framework 4.7.2 has rolled out more before issuing this warning (and corresponding info bar). |
Contributor
Author
|
@Pilchie for P5 approval |
dsplaisted
approved these changes
Jul 9, 2018
Member
|
Approved - thanks @nguerrera |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the code and test changes from commit 78b4b0b, but it keeps the warning message in .resx/.xlf as the warning will be reintroduced in a later version and we need to keep the warning code reserved for it.