Add snapshot tests for 5.0 and 6.0 Blazor WASM apps#23992
Merged
Conversation
ghost
added
the
Area-AspNetCore
javiercn
approved these changes
Feb 17, 2022
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks good, you might want to consider using the baselines functionality for the tests as is more exhaustive with the published files.
Contributor
Author
|
Are the baslines specific to build tests? I didn't see anything about baselines in the publish tests: https://github.com/dotnet/sdk/blob/main/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmPublishIntegrationTest.cs#L25-L55? |
Member
|
I think we might have a bit of overlap in these tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#28489
I picked the Blazor WASM hosted as smoke tests to verify we can continue building 5.0 / 6.0 apps. I did not add Blazor Server apps just to avoid enumerating over every scenario and spamming test assets.