Fix dogfood in build.sh#2542
Closed
sbomer wants to merge 1 commit into
Closed
Conversation
Looks like it was broken by dotnet#2178
Member
Author
|
@nguerrera PTAL. I can't seem to add reviewers to this PR. |
nguerrera
approved these changes
Sep 20, 2018
Contributor
|
This looks good to me. cc @livarcocc, @dotnet/dotnet-cli to look as well:
|
Contributor
|
@nguerrera We should push this to earlier branches, I would say release/2.1.4xx. Also, yes, there will be a conflict with the arcade work. I will make sure to merge that. |
Merged
Contributor
|
I'll cherry-pick this and fix it up along with some other needed fixes to dogfood. My care factor for fixing in downlevel branches is gone since the infrastructure is too divergent. Most dev activity is master/3.0+ now anyway. |
Contributor
|
This is now in PR at #2801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it was broken by #2178