Skip to content

MSBuild server V2#26104

Merged
baronfel merged 12 commits into
dotnet:mainfrom
AR-May:add-support-for-msbuild-server-v2
Jul 27, 2022
Merged

MSBuild server V2#26104
baronfel merged 12 commits into
dotnet:mainfrom
AR-May:add-support-for-msbuild-server-v2

Conversation

@AR-May
Copy link
Copy Markdown
Member

@AR-May AR-May commented Jun 20, 2022

Feature to improve inner loop experience of building small project. This would make building faster.
Previous attempts: #17916, #18263.

The change makes sense after merging MSBuild server PR and its insertion to SDK.

Implementation:

Modify SDK to set MSBUILDUSESERVER = 1
Implement escape hatches DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER= 1

@ghost ghost added the Area-CLI label Jun 20, 2022
@AR-May AR-May requested a review from rokonec June 20, 2022 16:57
rokonec
rokonec reviewed Jun 20, 2022
View reviewed changes
Comment thread src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs
rokonec
rokonec reviewed Jun 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rokonec rokonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discus my comment offline.

@AR-May AR-May requested a review from rokonec June 24, 2022 15:59
@baronfel
Copy link
Copy Markdown
Member

baronfel commented Jun 29, 2022

Should MSBuild Server participate in dotnet build-server shutdown? I mentioned this off-hand to Rainer and he said there might not be an similar concept readily available for MSBuild to use.

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jun 29, 2022 via email

@baronfel
Copy link
Copy Markdown
Member

baronfel commented Jun 29, 2022

The intent of the shutdown command is to give users a way to 'reset' any state that may have been persistent in long-running processes like the roslyn/razor compilation servers. It seems a natural fit for us to add ourselves to that list too for completeness' sake.

@AR-May
Copy link
Copy Markdown
Member Author

AR-May commented Jul 11, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 11, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Forgind
Forgind reviewed Jul 13, 2022
View reviewed changes
Comment thread src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs
@Forgind Forgind mentioned this pull request Jul 14, 2022
Merged
@v-wuzhai
Copy link
Copy Markdown
Contributor

v-wuzhai commented Jul 14, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 14, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Copy Markdown
Member Author

AR-May commented Jul 14, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 14, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Copy Markdown
Member Author

AR-May commented Jul 15, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Copy Markdown
Member Author

AR-May commented Jul 15, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Jul 15, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 15, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 22, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Copy Markdown
Member Author

AR-May commented Jul 25, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 25, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Copy Markdown
Member Author

AR-May commented Jul 25, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 25, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Copy Markdown
Member Author

AR-May commented Jul 25, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 25, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 26, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 27, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 27, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Copy Markdown
Member

rokonec commented Jul 27, 2022

@baronfel @marcpopMSFT We, MSBuild perf team, did lots of testing and have high enough confidence to consider this PR ready to merge.

@baronfel
Copy link
Copy Markdown
Member

baronfel commented Jul 27, 2022

merging! Great work landing this, folks - let's get dogfooding going to get early feedback.

@baronfel baronfel merged commit aef5b12 into dotnet:main Jul 27, 2022
@baronfel baronfel mentioned this pull request Jul 28, 2022
Closed
@sebastienros
Copy link
Copy Markdown
Member

sebastienros commented Sep 15, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rokonec rokonec rokonec approved these changes

+1 more reviewer

@Forgind Forgind Forgind left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AR-May @baronfel @rokonec @v-wuzhai @Forgind @sebastienros