add class templates#29655
Merged
YuliiaKovalova merged 17 commits intodotnet:release/7.0.2xxfrom Dec 26, 2022
Merged
Conversation
…ova/add_class-tempaltes_7.0.2
…)" This reverts commit 18eb1ab.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
YuliiaKovalova
added
the
Area-dotnet new
JanKrivanek
reviewed
Dec 23, 2022
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Overall looks good.
I have just few comments I'd like to understand more background about them before signing off
vlada-shubina
added
the
Area-Common templates
| vmImage: 'macOS-latest' | ||
| ${{ if eq(variables['System.TeamProject'], 'public') }}: | ||
| helixTargetQueue: OSX.1015.Amd64.Open | ||
| helixTargetQueue: OSX.1100.Amd64.Open |
Member
There was a problem hiding this comment.
Not related to the PR: we don't use helix - this should be removed. @GangWang01 could you please check it? Thank you.
vlada-shubina
approved these changes
Dec 23, 2022
Member
vlada-shubina
left a comment
vlada-shubina
left a comment
There was a problem hiding this comment.
Looks good, just consider more test cases (but they can be also added later in separate PR).
This was referenced Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related to #28915 and #1713.
New C# item templates are added for creating:
class
interface
record
enum
struct
in existing project
Checks:
[*]Added unit tests
Added #nullable enable to all the modified files N/A