Delete regex timeout#30347
Merged
ViktorHofer merged 2 commits intomainfrom Feb 5, 2023
Merged
Conversation
Fixes dotnet/runtime#81543 As discussed in dotnet/runtime, a regex timeout isn't necessary as the tool currently doesn't run in a security sensitive environment in our core stack repositories and customers aren't expected to be using this functionality in such an environment either. When ApiCompat upgrades and targets .NET 7+, we should also leverage the `RegexOptions.NonBacktracking` mode.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
approved these changes
Feb 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#81543
As discussed in dotnet/runtime, a regex timeout isn't necessary as the tool currently doesn't run in a security sensitive environment in our core stack repositories and customers aren't expected to be using this functionality in such an environment either.
When ApiCompat upgrades and targets .NET 7+, we should also leverage the
RegexOptions.NonBacktrackingmode.