Skip to content

[wasm] Remove UsingMicrosoftNETSdkBlazorWebAssembly from Wasm SDK#34166

Merged
maraf merged 2 commits intodotnet:mainfrom
maraf:WasmSdkNoBlazorSdk
Sep 22, 2023
Merged

[wasm] Remove UsingMicrosoftNETSdkBlazorWebAssembly from Wasm SDK#34166
maraf merged 2 commits intodotnet:mainfrom
maraf:WasmSdkNoBlazorSdk

Conversation

@maraf
Copy link
Member

@maraf maraf commented Jul 21, 2023 •
edited
Loading

@maraf maraf self-assigned this Jul 21, 2023
@ghost ghost added the untriaged Request triage from a team member label Jul 21, 2023
@lewing lewing closed this Jul 31, 2023
@lewing lewing reopened this Jul 31, 2023
@maraf
Copy link
Member Author

maraf commented Aug 14, 2023

The condition in the https://github.com/dotnet/emsdk/blob/67c120209017edd0427ceef963a200e7d5bacac4/eng/nuget/Microsoft.NET.Workload.Emscripten.Current.Manifest/WorkloadManifest.targets#L12 is not correct 🤦‍♂️

@lewing
Copy link
Member

lewing commented Aug 19, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Aug 21, 2023

The second PR in emsdk didn't flown to runtime yet

@maraf maraf closed this Sep 20, 2023
@maraf maraf reopened this Sep 20, 2023
@maraf maraf merged commit bdfa7a1 into dotnet:main Sep 22, 2023
@maraf maraf deleted the WasmSdkNoBlazorSdk branch September 22, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radical radical radical approved these changes

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@maraf maraf

Labels

Area-WasmSdk untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maraf @lewing @radical