Re-enable test that was blocking codeflow#41135
Merged
agocke merged 1 commit intodotnet:release/8.0.1xxfrom May 24, 2024
Merged
Re-enable test that was blocking codeflow#41135agocke merged 1 commit intodotnet:release/8.0.1xxfrom
agocke merged 1 commit intodotnet:release/8.0.1xxfrom
Conversation
This test is running `GetValuesCommand` with `PublishTrimmed` set to `true` in the generated `<project>.WriteValuesToFile.g.targets`. In the failure case, `ImportProjectExtensionProps` is false (due to https://github.com/dotnet/msbuild/blob/147ecadd19ae031d5a511ad55908cff9bcdc17c5/src/Tasks/Microsoft.Common.props#L68 imported from full framework MSBuild props) during restore, so this file isn't imported, we don't set `PublishTrimmed`, Microsoft.NET.ILLink.Tasks isn't restored, and then `ILLinkTargetsPath` never gets set. I was wondering why this wasn't failing in main on .NET Core, and found that the `GetValuesCommand` behavior was fixed as part of dotnet#39088 to not rely on `ImportProjectExtensionProps`. So an alternative fix would be to backport the GetValuesCommand fix. This change is just a simpler fix to set `PublishTrimmed` in the project file for this testcase.
ghost
added
nagilson
approved these changes
May 23, 2024
Member
nagilson
left a comment
nagilson
left a comment
There was a problem hiding this comment.
Thank you for following up with us, your investigation looks solid to me! We should probably add backporting that to our agenda at some point but 8.0.1 is kinda on lockdown atm.
@marcpopMSFT Do we need to take a test change thru servicing for 8 0 100 right now?
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is running
GetValuesCommandwithPublishTrimmedset totruein the generated<project>.WriteValuesToFile.g.targets. In the failure case,ImportProjectExtensionPropsis false (due tohttps://github.com/dotnet/msbuild/blob/147ecadd19ae031d5a511ad55908cff9bcdc17c5/src/Tasks/Microsoft.Common.props#L68 imported from full framework MSBuild props) during restore, so this file isn't imported, we don't set
PublishTrimmed, Microsoft.NET.ILLink.Tasks isn't restored, and thenILLinkTargetsPathnever gets set.I was wondering why this wasn't failing in main on .NET Core, and found that the
GetValuesCommandbehavior was fixed as part of #39088 to not rely onImportProjectExtensionProps. So an alternative fix would be to backport the GetValuesCommand fix.This change is just a simpler fix to set
PublishTrimmedin the project file for this testcase.fixes #40882