Avoid UsingTask when the target does not exist#42238
Merged
jjonescz merged 1 commit intodotnet:mainfrom Jul 18, 2024
Merged
Conversation
ghost
added
jjonescz
requested review from
baronfel,
dsplaisted,
jaredpar,
marcpopMSFT and
rainersigwald
rainersigwald
approved these changes
Jul 18, 2024
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
My only concern here is the silent fallback to previous (bad) behavior if restore is done outside of VS and then VS doesn't retrigger restore. This definitely seems like an improvement.
Member
Author
If we follow up with #42216 there will be no silent fallback (we will instead report an error if we cannot find the package during compilation). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #41791.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2136930.