Use PortableRid config value for self-contained publish test#43234
Merged
mthalman merged 1 commit intodotnet:mainfrom Sep 5, 2024
Merged
Use PortableRid config value for self-contained publish test#43234mthalman merged 1 commit intodotnet:mainfrom
mthalman merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
MichaelSimons
approved these changes
Sep 4, 2024
Member
|
Should this be backported to 9.0 as the current functionality is not intentional? |
Member
Author
|
/backport to release/9.0.1xx |
Contributor
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10720600856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4585
It's not clear what changed that caused the issue in dotnet/source-build#4585. But this fixes it by ensuring that the RID for the self-contained test is set to the
PortableRidconfig value. This ensures thatlinux-musl-<arch>will be used in an Alpine environment.