Add parsing and flag for -bl for MSbuild-related commands#43322
Add parsing and flag for -bl for MSbuild-related commands#43322baronfel wants to merge 2 commits intodotnet:release/9.0.1xxfrom
-bl for MSbuild-related commands#43322Conversation
| } | ||
|
|
||
| static void InvokeRunArgumentsTarget(ProjectInstance project, string[] restoreArgs, VerbosityOptions? verbosity) | ||
| static void InvokeRunArgumentsTarget(ProjectInstance project, string[] restoreArgs, BinlogArgs? binlogArgs, VerbosityOptions? verbosity) |
There was a problem hiding this comment.
@mariam-abdulla here's how I used the bl option to correctly forward along binlog information. Add the option to your parser, get the value from the parser, and then use the data structure to create the BinaryLogger you need (if any).
|
This is what I was afraid of - we can't define -bl can be supplied as a flag and as an option that has some configuration: a binlog filename to create and/or a directive how to manage the files that are imported into the binlog. We can't enforce the MSbuild syntax requirement here of |
Fix #43310 by explicitly modeling the flag (including argument parsing as described/implemented by MSBuild).
cc @rainersigwald for more MSBuild arg bindings