Fix processing non-public classes and generic types in AssemblyScheduler.cs#43377
Merged
akoeplinger merged 1 commit intomainfrom Sep 12, 2024
Merged
Fix processing non-public classes and generic types in AssemblyScheduler.cs#43377akoeplinger merged 1 commit intomainfrom
akoeplinger merged 1 commit intomainfrom
Conversation
ghost
added
Contributor
|
If the type is nested, I think ShouldIncludeType should also check the visibility of the containing type, in principle. But perhaps your test assemblies don't define any types for which this would matter. |
Member
Author
|
Yeah it's not common and xunit won't run them anyway so we don't need to be 100% correct here, this just makes the calculation of the number of Helix partitions more accurate. |
tmat
approved these changes
Sep 12, 2024
Member
Author
|
I see a slightly different test count when comparing this PR with main so let's not merge yet. |
Member
Author
|
Ok false alarm, this is because a Helix workitem also gets reported as an AzDO test result and we're running a couple fewer workitems due to the new partitioning. I verified the number of actual tests is the same. |
tmat
pushed a commit
to tmat/sdk
that referenced
this pull request
Sep 18, 2024
…ler.cs (dotnet#43377) While looking at why dotnet#43295 is having issues running on Helix I noticed that we were passing ``-class "Microsoft.WebTools.AspireServer.UnitTests.MockFactory`1"`` to the test script which caused a parse error because of the backtick. We shouldn't pass generic types since xunit can't do anything with it. Additionally I noticed that we were passing some nested types even though they were internal. This is because we didn't check the visibility correctly, we must use `TypeAttributes.VisibilityMask` to check for just the visibility (the same also applies to checking for class). See https://learn.microsoft.com/en-us/dotnet/api/system.reflection.typeattributes?view=net-8.0&redirectedfrom=MSDN#examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at why #43295 is having issues running on Helix I noticed that we were passing
-class "Microsoft.WebTools.AspireServer.UnitTests.MockFactory`1"to the test script which caused a parse error because of the backtick.We shouldn't pass generic types since xunit can't do anything with it.
Additionally I noticed that we were passing some nested types even though they were internal.
This is because we didn't check the visibility correctly, we must use
TypeAttributes.VisibilityMaskto check for just the visibility (the same also applies to checking for class).See https://learn.microsoft.com/en-us/dotnet/api/system.reflection.typeattributes?view=net-8.0&redirectedfrom=MSDN#examples