Revert "Clean up error experience when downloading non-tools (#43045)"#43872
Merged
Conversation
ghost
added
baronfel
approved these changes
Oct 3, 2024
joeloff
added
Servicing-consider
Servicing-approved
and removed
Area-Infrastructure
untriaged
|
Since the linked issues mostly mentioned Artifactory as 3rd party, I wanted to also mention GitHub packages as not working. Just ran into it when upgrading our GitHub actions from RC1 to RC2. Will stick with RC1 for now as workaround. |
Member
|
Also the error message was not helpful, "X is not a tool" where in reality the http request to the feed was returning 401 |
This(!) has given me a real headache. Glad i found a PR and issues about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We made some changes to detect non-tool packages in RC.2. These changes relied on APIs supported by NuGet, but 3rd party feeds like Artifactory do not necessary support these (#43651). We're rolling back the changes for GA and will consider a different approach for 9.0.2xx. We've since identified additional issues that require further investigation and discussions.
Impact
Users are unable to install tool packages properly when using 3rd party feeds and some global tool operations may fail as well. There is no workaround for this.