fix port error when fallback to http#44050
Merged
baronfel merged 4 commits intodotnet:mainfrom Oct 16, 2024
dameng324:main
Merged
fix port error when fallback to http#44050baronfel merged 4 commits intodotnet:mainfrom dameng324:main
baronfel merged 4 commits intodotnet:mainfrom
dameng324:main
Conversation
baronfel
reviewed
Oct 10, 2024
This was referenced Oct 10, 2024
tmds
reviewed
Oct 10, 2024
baronfel
approved these changes
Oct 10, 2024
Member
baronfel
left a comment
There was a problem hiding this comment.
Thanks for adding the tests!
Contributor
Author
|
@baronfel the work is done,can you spare some time to check? |
Member
|
This LGTM, thanks @dameng324! I kicked CI to see if those two failing legs can get green. If so, we'll merge and I'll backport the fix to 8.0.400 and 9.0.100 and work on getting approval for those. |
This was referenced Oct 16, 2024
Member
|
/backport to release/8.0.4xx |
Member
|
/backport to release/9.0.1xx |
Contributor
|
Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/11370820390 |
Contributor
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/11370821680 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in previous PR: #43620,
I pass the original
registryNametoFallbackToHttpMessageHandlerand check it if contains a port or not. If not, set theuriBuilder.Port = -1.For summary. It should behave like this:
Fixed: #43618 , dotnet/sdk-container-builds#588