Skip to content

[release/9.0.1xx] Update dependencies from dotnet/runtime#44257

Merged
v-wuzhai merged 1 commit intorelease/9.0.1xxfrom
darc-release/9.0.1xx-c32f9de8-85e8-4272-bc93-ea178be8023d
Oct 17, 2024
Merged

[release/9.0.1xx] Update dependencies from dotnet/runtime#44257
v-wuzhai merged 1 commit intorelease/9.0.1xxfrom
darc-release/9.0.1xx-c32f9de8-85e8-4272-bc93-ea178be8023d

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro Bot commented Oct 17, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: fbe40687-4477-491b-ebc0-08dcbc3038ad
  • Build: 20241016.10
  • Date Produced: October 17, 2024 4:05:58 AM UTC
  • Commit: d3981726bc8b0e179db50301daf9f22d42393096
  • Branch: refs/heads/release/9.0

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
5001bf7 
…1016.10

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rtm.24516.5 -> To Version 9.0.0
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 17, 2024
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Oct 17, 2024

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@v-wuzhai v-wuzhai merged commit 71ca554 into release/9.0.1xx Oct 17, 2024
@v-wuzhai v-wuzhai deleted the darc-release/9.0.1xx-c32f9de8-85e8-4272-bc93-ea178be8023d branch October 17, 2024 07:05
@mthalman
Copy link
Copy Markdown
Member

mthalman commented Oct 17, 2024

@v-wuzhai - Why was this merged? The sdk-source-build build was failing in this PR and caused a regression: dotnet/source-build#4679.

@mthalman mthalman mentioned this pull request Oct 17, 2024
Merged
@LoopedBard3 LoopedBard3 mentioned this pull request Oct 17, 2024
Closed
@v-wuzhai
Copy link
Copy Markdown
Contributor

v-wuzhai commented Oct 18, 2024

@mthalman Sorry about that, looks like the sdk-source-build leg didn't finish running. I probably didn't notice it during the comparison. @marcpopMSFT I'm curious why I was able to merge in this situation?

@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Oct 18, 2024

I think this is fallout from us trying to fix the maestro bot for other branches when the source build leg is skipped. We marked it as not required in a bunch of branches including this one and so it doesn't block but it won't auto-merge since it's still running. Let me see if I can resolve that for the 1xx branch at least though source build shouldn't be required for the other branches.

@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Oct 18, 2024

hmm, I just checked and the darc policy isn't set to ignore that leg for this branch so my theory appears to be wrong. @dotnet/dnceng have any ideas why v-wuzhai could merge while the leg was still running?

@ghost
Copy link
Copy Markdown

ghost commented Oct 18, 2024

Is the source build check part of the required checks in the branch protection rules for the repo? (an admin will have to check)

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-status-checks-before-merging

@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Oct 18, 2024

It is not. That explains it. GH doesn't have a great way of managing this other than me creating branch protection rules that are different for every branch. I've been trying to avoid that as a single central rule is far easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@v-wuzhai v-wuzhai v-wuzhai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mthalman @v-wuzhai @marcpopMSFT