Skip to content

[release/9.0.2xx] Update dependencies from dotnet/msbuild#44283

Merged
baronfel merged 2 commits intorelease/9.0.2xxfrom
darc-release/9.0.2xx-324c3824-d6c6-44b4-a143-5fe39bb2371b
Oct 17, 2024
Merged

[release/9.0.2xx] Update dependencies from dotnet/msbuild#44283
baronfel merged 2 commits intorelease/9.0.2xxfrom
darc-release/9.0.2xx-324c3824-d6c6-44b4-a143-5fe39bb2371b

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: ec91df1d-8e6d-40cf-80b3-4ef102298e66
  • Build: 20241017.5
  • Date Produced: October 17, 2024 8:11:55 AM UTC
  • Commit: b8f46eb171f3b1c7e3bddb8afaff9fbb0ba59e9d
  • Branch: refs/heads/main

…1017.5

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.13.0-preview-24514-17 -> To Version 17.13.0-preview-24517-05
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Oct 17, 2024
@baronfel
Copy link
Copy Markdown
Member

The source-build prebuilt should be able to be addressed - we have vs-solutionpersistence in source-build-externals at version 1.0.9 already.

@baronfel
Copy link
Copy Markdown
Member

This codeflow PR brings slnx-building support to the sdk, as part of the overall effort tracked in #40913.

Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nm, typed in wrong box]

@rainersigwald rainersigwald requested a review from a team as a code owner October 17, 2024 19:31
<UsagePattern IdentityGlob="System.Security.Cryptography.ProtectedData/*7.0.0*" />

<!-- Transitive dependencies from MSBuild -->
<UsagePattern IdentityGlob="Microsoft.VisualStudio.SolutionPersistence/1.0.9" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be defined. If a prebuilt is occurring, it means that the necessary version of source-build-externals is not being referenced. This was only merged to the main branch: dotnet/source-build-externals#392. That doesn't flow to 9.0.2xx. It will need to be backported to release/9.0.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I wasn't thinking. This is for 9.0.2xx which isn't source built. So it should be ok to allow this as a prebuilt. Is that ok, @MichaelSimons?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be fine to add as an allowed prebuilt but I would not want this backported to main. In main we want to make sure this is handled correctly.

@baronfel baronfel merged commit 798eb4c into release/9.0.2xx Oct 17, 2024
@baronfel baronfel deleted the darc-release/9.0.2xx-324c3824-d6c6-44b4-a143-5fe39bb2371b branch October 17, 2024 22:31
@baronfel
Copy link
Copy Markdown
Member

Hey @mmitche - I was told you were interested in pipelines that didn't go fully green when the source-build and/or unified-build legs were skipped. This was one such pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants