Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.24556.1#44685
Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.24556.1#44685
Conversation
There was a problem hiding this comment.
Can we re-bootstrap to a newer Arcade.Sdk? I see this points to https://github.com/dotnet/arcade/tree/1818ed2babf890a1cd62fa96a1f03abdada2d003. It would be great if we could have dotnet/arcade@e0270d6 included (or ideally main HEAD).
Asking as that newer commit will allow fixing dotnet/source-build#4719
|
@mthalman I pushed into your branch as I noticed that we don't consistently set NetCurrent to net10.0. We only set it for a set of projects (which don't import Arcade). That was overlooked in the previous net10.0 TFM PR. Hope that's OK. |
We really shouldn't. The arcade, SDK, and previous SB artifacts should all be from the same build. Deviating from this often leads to prebuilts and other possible breaks. I would rather we just rebootstrap again once a build is available with the arcade fix. We have automation for this now so it can be as simple as queuing a build. |
|
Isn't a build with the Arcade fix already available? Oh I just noticed that the full source-build pipeline only runs once per day. Understood. |
Ah, so that probably explains why dotnet/source-build#4720 is happening. |
|
Arcade is failing to build in sdk-source-build: Looks like we'll need the fix at dotnet/arcade@e0270d6. I'll get a full run of source build with this fix that we can use to bootstrap with. |
|
This one is different. Arcade consumes an sdk package but sdk already updated their TFM to net10.0. Arcade is still on net9.0. |
Ah. Do you know of any blockers to getting it on net10.0? |
|
Nope. The blocker got fixed yesterday with the net10.0 PR merged. |
|
I'll probably create a patch for this. I know there's been pushback in the past about arcade upgrading to a new TFM too early. |
|
Here's the Arcade PR: dotnet/arcade#15221. Feel free to create a patch from it. |
|
You probably also need the latest commit from dotnet/arcade#15221. That was an unintentional change that I fixed with it. |
|
Source build error in nuget-client:
This is the same issue that was identified in #44540. |
|
Looks like we may need another change similar to NuGet/NuGet.Client#5911? cc @akoeplinger |
|
I added a patch to update nuget-client to |
|
Is the plan with this PR to patch all VMR repositories to target net10.0? |
Re-Bootstrap Source Build to .NET 10.0.100-alpha.1.24556.1
Fixes dotnet/source-build#4720