Skip to content

[release/9.0.2xx] Expand MSBuildSdkResolver#45459

Merged
marcpopMSFT merged 26 commits intorelease/9.0.2xxfrom
backport/pr-45364-to-release/9.0.2xx
Dec 17, 2024
Merged

[release/9.0.2xx] Expand MSBuildSdkResolver#45459
marcpopMSFT merged 26 commits intorelease/9.0.2xxfrom
backport/pr-45364-to-release/9.0.2xx

Conversation

@github-actions
Copy link
Contributor

Backport of #45364 to release/9.0.2xx

/cc @surayya-MS

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Dec 13, 2024
@surayya-MS
Copy link
Member

surayya-MS commented Dec 16, 2024

Changes made in the backport PR (different from the original PR in main):

  1. nullability check in MSBuildSdkResolver
  2. fixed tests for unix as dotnet.exe does not exist (these tests were not run in main branch on unix platforms checks for some reason)

fyi @v-wuzhai for conflict resolution in automated PR back to main

@surayya-MS
Copy link
Member

surayya-MS commented Dec 17, 2024

This PR has been failing on macOS arm64 check for few times now. @marcpopMSFT could you please merge this on red?

Also, could you please trigger the VS insertion after this is merged? We want this in as a part of Decoupling VS builds of .NET SDK projects to unblock roslyn team

cc @baronfel @rainersigwald

@marcpopMSFT
Copy link
Member

Yeah, we're tracking offline with the dnceng folks to try to determine why the arm64 leg is timing out tests. We've made that leg no longer required in main for merge but I haven't updated 2xx yet as I was hoping we'd have a solution by now.

@marcpopMSFT marcpopMSFT disabled auto-merge December 17, 2024 17:39
@marcpopMSFT marcpopMSFT merged commit abd7d1c into release/9.0.2xx Dec 17, 2024
@marcpopMSFT marcpopMSFT deleted the backport/pr-45364-to-release/9.0.2xx branch December 17, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants