Skip to content

[main] Update dependencies from dotnet/runtime#45500

Merged
dotnet-maestro[bot] merged 5 commits intomainfrom
darc-main-163c8da4-dc7c-4c8e-a22c-ebe27bc65f2c
Dec 17, 2024
Merged

[main] Update dependencies from dotnet/runtime#45500
dotnet-maestro[bot] merged 5 commits intomainfrom
darc-main-163c8da4-dc7c-4c8e-a22c-ebe27bc65f2c

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro Bot commented Dec 17, 2024 •
edited
Loading

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport: from 10.0.0-alpha.1.24575.2 to 10.0.0-alpha.1.24613.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)
    • Microsoft.SourceBuild.Intermediate.emsdk: from 10.0.0-alpha.1.24575.2 to 10.0.0-alpha.1.24613.1 (parent: Microsoft.NETCore.App.Runtime.win-x64)

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20241217.1
  • Date Produced: December 17, 2024 1:08:39 PM UTC
  • Commit: 9482c1ed378dfde2f540b99cb99685396b3bd4c2
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
801eb7e 
…1216.9

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24616.1 -> To Version 10.0.0-alpha.1.24616.9

Dependency coherency updates

Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport,Microsoft.SourceBuild.Intermediate.emsdk
 From Version 10.0.0-alpha.1.24575.2 -> To Version 10.0.0-alpha.1.24613.1 (parent: Microsoft.NETCore.App.Runtime.win-x64
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Dec 17, 2024
@akoeplinger akoeplinger enabled auto-merge (squash) December 17, 2024 09:33
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Dec 17, 2024

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2024…
f72dc06 
…1217.1

Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Formats.Asn1 , System.IO.Hashing , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.10.0 , VS.Redist.Common.NetCore.TargetingPack.x64.10.0
 From Version 10.0.0-alpha.1.24616.1 -> To Version 10.0.0-alpha.1.24617.1
@akoeplinger akoeplinger disabled auto-merge December 17, 2024 14:59
@build-analysis build-analysis Bot mentioned this pull request Dec 17, 2024
Open
@akoeplinger akoeplinger mentioned this pull request Dec 17, 2024
Closed
@marcpopMSFT
Copy link
Copy Markdown
Member

marcpopMSFT commented Dec 17, 2024

The remaining failure is on linux and the workloads test. It's expecting wasi-experimental. I wonder if we should just remove that check as it was added here: https://github.com/dotnet/sdk/pull/42062/files to fix the test but it doesn't seem needed anymore.

CC @dsplaisted @lewing @steveisok on thoughts as to why multi-targeting on linux would report back wasi-experimental as that seems like our prior issues with dotnet restore. I'm going to proactively remove that since it's the holidays and this is main.

@akoeplinger
Copy link
Copy Markdown
Member

akoeplinger commented Dec 17, 2024 •
edited
Loading

@marcpopMSFT I looked at this a bit and filed #45516 and disabled the tests for now. From what I can see we seem to be looking at the number of packs and suggest the workload with the lowest number of packs:

sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadSuggestionFinder.cs

Lines 192 to 200 in a2dad1e

internal static WorkloadSuggestion GetBestSuggestion(ICollection<WorkloadSuggestion> suggestions) => FindBest(
suggestions,
(x, y) => y.ExtraPacks - x.ExtraPacks,
(x, y) => y.Workloads.Count - x.Workloads.Count);
/// <summary>
/// Gets the suggestion with the lowest number of extra packs and lowest number of workload IDs.
/// </summary>
public WorkloadSuggestion GetBestSuggestion() => GetBestSuggestion(UnsortedSuggestions);

It doesn't make much sense to me.

@dotnet-maestro dotnet-maestro Bot merged commit e5fc5f0 into main Dec 17, 2024
@dotnet-maestro dotnet-maestro Bot deleted the darc-main-163c8da4-dc7c-4c8e-a22c-ebe27bc65f2c branch December 17, 2024 21:36
@akoeplinger akoeplinger mentioned this pull request Dec 20, 2024
Merged
akoeplinger added a commit that referenced this pull request May 19, 2025
@akoeplinger
Reenable tests in WorkloadTests.cs
694cdbf 
Those were disabled as part of #45500 but looks like they can be reenabled: #45516 (comment)
@akoeplinger akoeplinger mentioned this pull request May 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcpopMSFT @akoeplinger