simplify sln-remove implementation

[kasperk81]

complex linq expressions, multiple dictionaries and recursion is hardly necessary for this simple command

[kasperk81]

@Forgind @baronfel

[Forgind]

I don't really have a strong preference between these two versions, to be honest. I think edvilme's version is a bit more understandable, especially as I normally think tree structures lend themselves well to recursive procedures. kasperk81's version should be faster and allocate less.

[kasperk81]

I don't really have a strong preference between these two versions, to be honest. I think edvilme's version is a bit more understandable, especially as I normally think tree structures lend themselves well to recursive procedures. kasperk81's version should be faster and allocate less.

using .Where.GroupBy.ToDictionary then keeping track of caches in other dictionaries with a recursive call is significantly worse than this simple loop in every regard. this version offers implementation that has less lines of codes, less calls, performant and reduced allocations

[edvilme]

Nice property pattern :)

[edvilme]

This looks good to me, my main concern would most likely be readability, but I understand how many of the operations can come at a cost, especially for really large solution files

[kasperk81]

i'm not sure i'm following. this version is more readable with a single loop compared to multiple linq expressions, caching and recursion