ApiDiff: Allow deciding whether to include partial modifier in TypeDeclarationCSharpSyntaxRewriter output#45803
Merged
carlossanlop merged 2 commits intodotnet:mainfrom Jan 9, 2025
carlossanlop:ApiDiffPart2
Merged
ApiDiff: Allow deciding whether to include partial modifier in TypeDeclarationCSharpSyntaxRewriter output#45803carlossanlop merged 2 commits intodotnet:mainfrom carlossanlop:ApiDiffPart2
carlossanlop merged 2 commits intodotnet:mainfrom
carlossanlop:ApiDiffPart2
Conversation
ghost
added
ViktorHofer
reviewed
Jan 9, 2025
ViktorHofer
reviewed
Jan 9, 2025
ViktorHofer
approved these changes
Jan 9, 2025
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
LGTM aside from the unnecessary field in the TypeDeclarationCSharpSyntax... type.
Contributor
Author
|
/ba-g Build failure is unrelated: Unable to find directory for jdk 11.0.24; please make sure the tool is installed on this image. #45834 |
…eclarationCSharpSyntaxRewriter or not.
ViktorHofer
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389
This change adds a boolean parameter to the TypeDeclarationCSharpSyntaxRewriter to allow callers to decide whether to include the partial modifier in the output or not.