ApiDiff: Move ImplicitSymbolFilter from GenAPI.Filtering to ApiSymbolExstensions.Filtering#45806
Merged
dsplaisted merged 3 commits intodotnet:mainfrom Jan 9, 2025
carlossanlop:ApiDiffPart3
Merged
ApiDiff: Move ImplicitSymbolFilter from GenAPI.Filtering to ApiSymbolExstensions.Filtering#45806dsplaisted merged 3 commits intodotnet:mainfrom carlossanlop:ApiDiffPart3
dsplaisted merged 3 commits intodotnet:mainfrom
carlossanlop:ApiDiffPart3
Conversation
…icrosoft.DotNet.ApiSymbolExstensions.Filtering.
ghost
added
ViktorHofer
approved these changes
Jan 9, 2025
Contributor
Author
|
/ba-g Failure is unrelated: #45842 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389
The purpose of this change is to make ImplicitSymbolFilter available at a higher level by moving it from Microsoft.DotNet.GenAPI.Filtering to Microsoft.DotNet.ApiSymbolExtensions.Filtering.
Edit: I just realized this change depends on #45801 so we need to merge that one first. But this PR can still be reviewed in the meanwhile.