Rename host key to _EXPERIMENTAL namespace to prevent SDK task failures#46248
Merged
vseanreesermsft merged 1 commit intodotnet:release/9.0.2xxfrom Jan 23, 2025
Merged
Conversation
ghost
added
baronfel
changed the title
rainersigwald
approved these changes
Jan 23, 2025
jaredpar
approved these changes
Jan 23, 2025
joeloff
approved these changes
Jan 23, 2025
Member
joeloff
left a comment
joeloff
left a comment
There was a problem hiding this comment.
Long term we should maybe consider moving all the experimental properties into a separate class so we have them in a single place and people don't end up with typos
Member
Author
|
@joeloff long term I don't want to have any experimental properties :D I'd expect us to delete this by .NET 10 GA at the latest if all goes well! |
This was referenced Jan 23, 2025
vseanreesermsft
merged commit 843734d
into
dotnet:release/9.0.2xx
29 of 31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to VS testing of 9.0.200 finding several places in the SDK that were doing a combination of:
Because of this combination tasks would hard-error.
We're going to effectively unset this key by renaming it so that we can continue with progress on dotnet/msbuild#11142 while not impacting Tasks that need to be unified in their detection logic.