[ApiDiff] Add Microsoft.CodeAnalysis.Workspaces.Common dependency for upcoming GenApi and ApiDiff changes#46253
Merged
carlossanlop merged 3 commits intodotnet:mainfrom Jan 24, 2025
carlossanlop:WorkspacesCommonDependency
Merged
[ApiDiff] Add Microsoft.CodeAnalysis.Workspaces.Common dependency for upcoming GenApi and ApiDiff changes#46253carlossanlop merged 3 commits intodotnet:mainfrom carlossanlop:WorkspacesCommonDependency
carlossanlop merged 3 commits intodotnet:mainfrom
carlossanlop:WorkspacesCommonDependency
Conversation
…GenApi and ApiDiff changes.
ghost
added
ericstj
reviewed
Jan 23, 2025
ericstj
approved these changes
Jan 23, 2025
This was referenced Jan 24, 2025
baronfel
pushed a commit
to baronfel/sdk
that referenced
this pull request
Feb 24, 2025
… upcoming ApiDiff changes (dotnet#46253) Co-authored-by: Eric StJohn <ericstj@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389
The purpose of this change is to add the dependency to Microsoft.CodeAnalysis.Workspaces.Common, as it will be used in the upcoming change. The files adding this dependency are often showing merge conflicts due to the packages above and below changing often, making it very difficult to keep the PRs up to date.