[release/8.0.4xx] Multi-arch OCI images export as tarballs#46467
Merged
marcpopMSFT merged 54 commits intodotnet:release/8.0.4xxfrom Feb 11, 2025
Merged
[release/8.0.4xx] Multi-arch OCI images export as tarballs#46467marcpopMSFT merged 54 commits intodotnet:release/8.0.4xxfrom
marcpopMSFT merged 54 commits intodotnet:release/8.0.4xxfrom
Conversation
… docker publishing
…s it is not supported
baronfel
reviewed
Feb 2, 2025
src/Containers/Microsoft.NET.Build.Containers/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
MichalPavlik
approved these changes
Feb 6, 2025
…ctory; add ArchiveFileRegistryTests
rainersigwald
approved these changes
Feb 7, 2025
src/Containers/Microsoft.NET.Build.Containers/ImageIndexGenerator.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/LocalDaemons/ArchiveFileRegistry.cs
Outdated
Show resolved
Hide resolved
src/Containers/Microsoft.NET.Build.Containers/Tasks/CreateNewImage.cs
Outdated
Show resolved
Hide resolved
added 3 commits
February 10, 2025 09:17
…postory contains /, and 'docker.io/library/' when it doesn't; add tests
… rename DockerIsAvailableAndSupportsArchFactAttribute file
Member
|
I've done all my testing and am very happy with the changes here! Thanks for pushing this to done, @surayya-MS |
baronfel
approved these changes
Feb 10, 2025
Member
Author
|
A test is failing on macos leg - which is unrelated to the changes in this PR. @marcpopMSFT could you please merge this on red, once tactics approve the PR? |
Member
|
It's currently marked for do not merge and still servicing-consider. I can merge once it's approved. The Mac issue is #46006 and still waiting on a fix from Runtime. |
Member
|
@marcpopMSFT this was just approved over email - mind merging when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes dotnet/sdk-container-builds#609
This is a feature request from partner team - support publishing multi-arch OCI image as one combined tarball. Currently we publish separate tarballs for each architecture.
Customer impact
Without this feature customers will not be able to export multi-arch OCI image as one combined tarball, they will get separate tarballs for each architecture, and will have to combine them manually to achieve this.
Details
Current behavior for multi-arch image publishing
Behaviour after this PR
Note: in order to load a multi-arch oci image tarball, containerd image store should be enabled for Docker.
Changes made
DockerCli.CreateNewImagetask into a separate class, to be able to reuse it inCreateImageIndextask.SkipPublishingparameter inCreateNewImagetask, in order to create an image but skip publish it (this is needed for multi-arch tarball publishing because we need to publish one combined tarball)Testing
Modified end to end multi-arch tests to reflect the new behavior. Tested manually as well.
Risks
Low - new tests ensure the scenarios are now covered, the existing tests ensure that other scenarios were not affected.