Remove interactive special case for logger verbosity in dotnet run

[baronfel]

This lights up Terminal Logger support in dotnet run again, using the new factory function.

This also changes the verbosity override in anticipation of MSBuild identifying and always printing auth messages.

My initial version of this applied the verbosity by splatting it as an argument along with the other loose MSBuildArgs. This was hard to track. So I've also added Verbosity tracking to MSBuildArgs so we can set it with less string-munging. Here's the before-and-after of that change:

The first dotnet run I wasn't able to set quiet easily, so minimal kept getting applied, overwriting my quiet setting.
The second dotnet run is after I was able to track the Verbosity setting for MSBuild, and ensure we only sent one. The Building... is because this project did opt into building messages in its launchsettings.json.

[Copilot]

Pull Request Overview

This PR centralizes verbosity handling by moving VerbosityOptions into the Cli.Utils library, extending MSBuildArgs to carry verbosity state, and simplifying the dotnet run logger setup to use a single factory function.

• Add Verbosity property and related clone methods to MSBuildArgs and update AnalyzeMSBuildArguments to capture it.
• Remove ad-hoc interactive verbosity logic in RunCommand, replacing it with SetupSilentBuildArgs and a unified MakeTerminalLogger call.
• Update all command parsers and tests to use the new Utils.VerbosityOptions and propagate the verbosity option through AnalyzeMSBuildArguments.

Reviewed Changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Show a summary per file

File or Group	Description
test/dotnet.Tests/CommandTests/Tool/Update/UpdateToolParserTests.cs (and similar *ParserTests.cs files)	Swapped result.GetValue<T> calls for GetRequiredValue where appropriate.
test/dotnet.Tests/CommandTests/MSBuild/GivenDotnetRunInvocation.cs	Added RunCommandParser.VerbosityOption to the AnalyzeMSBuildArguments call.
test/Microsoft.DotNet.Tools.Tests.ComponentMocks/ToolPackageDownloaderMock2.cs	Updated overrides to use fully-qualified Cli.Utils.VerbosityOptions.
test/Microsoft.DotNet.PackageInstall.Tests/…ToolPackageInstallerNugetCacheTests.cs	Added using Microsoft.DotNet.Cli.Utils; for new verbosity enum.
src/Cli/dotnet/CommonOptions.cs & CommonOptionsExtensions.cs	Removed inline VerbosityOptions enum and updated imports to Utils.
src/Cli/Microsoft.DotNet.Cli.Utils/VerbosityOptions.cs & MSBuildArgs.cs & MSBuildForwardingAppWithoutLogging.cs	Introduced VerbosityOptions enum, added verbosity support to MSBuildArgs, and emitted --verbosity in forwarding.
src/Cli/dotnet/Commands/**	Updated all parsers and commands to use Utils.VerbosityOptions and pass the verbosity option to AnalyzeMSBuildArguments.

Comments suppressed due to low confidence (3)

src/Cli/dotnet/Commands/Run/RunCommand.cs:415

• [nitpick] The variable name thing is unclear—consider renaming it to something more descriptive like terminalLogger or logger.

        var thing = TerminalLogger.CreateTerminalOrConsoleLogger([$"--verbosity:{msbuildVerbosity}", ..buildArgs.OtherMSBuildArgs]);

src/Cli/dotnet/Commands/Run/RunCommand.cs:316

• [nitpick] Consider adding unit tests to verify that dotnet run correctly includes the --verbosity flag in MSBuildArgs for both default and explicit verbosity levels, ensuring SetupSilentBuildArgs and MakeTerminalLogger behave as intended.

    private MSBuildArgs SetupSilentBuildArgs(MSBuildArgs msbuildArgs)

test/Microsoft.DotNet.Tools.Tests.ComponentMocks/ToolPackageDownloaderMock2.cs:59

• The namespace qualifier Cli.Utils.VerbosityOptions may not resolve correctly; ensure you either add using Microsoft.DotNet.Cli.Utils; or fully qualify it as Microsoft.DotNet.Cli.Utils.VerbosityOptions.

        protected override void CreateAssetFile(PackageId packageId, NuGetVersion version, DirectoryPath packagesRootPath, string assetFilePath, string runtimeJsonGraph, Cli.Utils.VerbosityOptions verbosity, string? targetFramework = null)

[jjonescz]

Consider if we could make the equivalent enum items correspond to a single value like:

Suggested change

	quiet,
	q,
	minimal,
	m,
	normal,
	n,
	detailed,
	d,
	diagnostic,
	diag
	quiet,
	q = quiet,
	minimal,
	m = minimal,
	normal,
	n = normal,
	detailed,
	d = detailed,
	diagnostic,
	diag = diagnostic,

Which would make tests like verbosity == VerbosityOptions.quiet simpler (no need to check also for VerbosityOptions.q.

[baronfel]

I do agree with you, but I actually want to rewrite this enum entirely (I have a WIP branch) and handle that as a separate change.

[jjonescz]

It feels like there could be a shared utility function for this common pattern - creating TerminalLogger from LoggerVerbosity and OtherMSBuildArgs

[baronfel]

I think you're right - the Testing team especially may like that. @Evangelink?

[jjonescz]

I actually meant only in this repo, to share the code since I saw it repeating several times.

[baronfel]

I know - the test team has a lot of similar stuff to run in the test command in this repo :)

[Evangelink]

cc @dotnet/dotnet-testing