Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 24, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/templating

…0250623.4

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 9.0.108-servicing.25311.4 -> To Version 9.0.108-servicing.25323.4
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/templating:

@dotnet/templating-engine-maintainers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/templating) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…0250625.2

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 9.0.108-servicing.25311.4 -> To Version 9.0.108-servicing.25325.2
@SimonZhao888
Copy link
Member

SimonZhao888 commented Jun 26, 2025

@MiYanni, @marcpopMSFT, most GivenThatWeWantToBuild test cases fail because of the following reasons:

Microsoft.NET.TargetFrameworkInference.targets(187,5): warning NETSDK1215: Targeting .NET Standard prior to 2.0 is no longer recommended. See https://aka.ms/dotnet/dotnet-standard-guidance for more details. [Q:\SDK\artifacts\tmp\Debug\It_builds_the---209C4D06\TestLibrary\TestLibrary.fsproj]
Microsoft.NET.TargetFrameworkInference.targets(187,5): warning NETSDK1215: Targeting .NET Standard prior to 2.0 is no longer recommended. See https://aka.ms/dotnet/dotnet-standard-guidance for more details. [Q:\SDK\artifacts\tmp\Debug\It_builds_the---209C4D06\TestLibrary\TestLibrary.fsproj]
error NU1202: Package System.ValueTuple 4.6.1 is not compatible with netstandard1.6 (.NETStandard,Version=v1.6). Package System.ValueTuple 4.6.1 supports:
error NU1202:   - net462 (.NETFramework,Version=v4.6.2)
error NU1202:   - net47 (.NETFramework,Version=v4.7)
error NU1202:   - net471 (.NETFramework,Version=v4.7.1)
error NU1202:   - netcoreapp2.0 (.NETCoreApp,Version=v2.0)
error NU1202:   - netstandard2.0 (.NETStandard,Version=v2.0)

When the lock is released, I want to bring 2a856e5 and 48a2a31 to release/9.0.1xx branch to fix the test failure. What do you think about this?

The same issue in PR 49535.

@marcpopMSFT
Copy link
Member

So you want to back port the test change that updates a bunch of tests to target netstandard2.0 instead of netstandard1.5? That seems like a reasonable thing to do. You could cherry pick that change into this branch and see if it passes checks fwiw. I guess it's possible targeting an older netstandard could break but we recommend 2.0 or 2.1 so I'm not too worried about the lost coverage.

dotnet-maestro bot added 2 commits June 27, 2025 07:40
…0250627.1

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 9.0.108-servicing.25311.4 -> To Version 9.0.108-servicing.25327.1
…0250703.3

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 9.0.108-servicing.25311.4 -> To Version 9.0.109-servicing.25353.3
dotnet-maestro bot and others added 2 commits July 4, 2025 03:55
…0250703.8

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Mocks
 From Version 9.0.108-servicing.25311.4 -> To Version 9.0.109-servicing.25353.8
…darc-release/9.0.1xx-f6fd8168-79af-42e2-bbc7-a0024c64e769
@nagilson nagilson enabled auto-merge July 10, 2025 21:23
@nagilson
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

…darc-release/9.0.1xx-f6fd8168-79af-42e2-bbc7-a0024c64e769
@SimonZhao888
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@nagilson nagilson merged commit 8128984 into release/9.0.1xx Jul 11, 2025
34 of 36 checks passed
@nagilson nagilson deleted the darc-release/9.0.1xx-f6fd8168-79af-42e2-bbc7-a0024c64e769 branch July 11, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants