Skip to content

[release/8.0.1xx] Use new ACR for registry image#49691

Merged
nagilson merged 4 commits intodotnet:release/8.0.1xxfrom
nagilson:nagilson/acr-8.0.1xx
Nov 10, 2025
Merged

[release/8.0.1xx] Use new ACR for registry image#49691
nagilson merged 4 commits intodotnet:release/8.0.1xxfrom
nagilson:nagilson/acr-8.0.1xx

Conversation

@nagilson
Copy link
Copy Markdown
Member

@nagilson nagilson commented Jul 8, 2025

Backport of #49677 to release/8.0.1xx

@nagilson nagilson requested a review from a team as a code owner July 8, 2025 17:40
@nagilson nagilson requested a review from a team July 8, 2025 17:41
@nagilson nagilson enabled auto-merge July 8, 2025 17:41
Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
@nagilson
Copy link
Copy Markdown
Member Author

nagilson commented Jul 8, 2025

@dotnet/sdk-container-builds-maintainers This one will require more code / updating to the oldest logic. Are those changes something we had service approval for in the past / is there a reason they werent ported to 8.0.100?

@nagilson nagilson added the Area-Containers Related to dotnet SDK containers functionality label Jul 8, 2025
@nagilson
Copy link
Copy Markdown
Member Author

nagilson commented Jul 8, 2025

Ok, so we need to fix the code here but even if we do that we will still be blocked by #49687

@marcpopMSFT
Copy link
Copy Markdown
Member

@nagilson what are the next steps to getting this unblocked for 8 (looks like 9 and main are green)? The PR appears to need a fix to DockerTestFixture.cs to add .GetAwaiter().GetResult(); For DockerRegistryManager.cs, that one is different enough from main that it's not as straight forward.

@nagilson
Copy link
Copy Markdown
Member Author

I am not familiar with why the codebase changed so much between 8 and 9. I could investigate that, but @dotnet/sdk-container-builds-maintainers know the code more than I do since they own it, and it would be more efficient for them to look into this. I will defer to them on that unless we want to bump the priority of this.

@marcpopMSFT
Copy link
Copy Markdown
Member

@dotnet/sdk-container-builds-maintainers can ya'll take a look? The containers tests are broken in the 8 branch and this PR needs some help getting it passing with code changes to the containers code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Containers Related to dotnet SDK containers functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants