Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TestProgressState class to improve code clarity and maintainability by consolidating duplicate logic and removing unused properties. The main focus is on cleaning up the test result reporting mechanism.
Key changes:
- Refactored three similar test reporting methods into a single generic method
- Removed unused properties (
ExitCode,FlakyTests) and comments - Added comprehensive test coverage for the TestProgressState class
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Test/TestProgressStateTests.cs | New comprehensive test file covering all scenarios for TestProgressState functionality |
| src/Cli/dotnet/Commands/Test/TestApplicationEventHandlers.cs | Removed outdated TODO comment about handling duplicate test results |
| src/Cli/dotnet/Commands/Test/Terminal/TestProgressState.cs | Major refactoring - consolidated duplicate logic into ReportGenericTestResult method and removed unused properties |
| src/Cli/dotnet/Commands/Test/Terminal/TerminalTestReporter.cs | Removed unused flaky test tracking logic and ExitCode property usage |
Comments suppressed due to low confidence (1)
test/dotnet.Tests/CommandTests/Test/TestProgressStateTests.cs:46
- The test is missing FluentAssertions using statement. The Should() extension method requires 'using FluentAssertions;' to be added to the imports.
state.SkippedTests.Should().Be(1);
ebbadf2 to
2f75af6
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Youssef1313
commented
Aug 5, 2025
Youssef1313
commented
Aug 5, 2025
Youssef1313
commented
Aug 5, 2025
…b.com/dotnet/sdk into dev/ygerges/cleanup-TestProgressState
nohwnd
reviewed
Aug 8, 2025
nohwnd
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48369