Add warnings for newer tool versions during `dotnet tool restore` by Copilot · Pull Request #51011 · dotnet/sdk

Copilot · 2025-09-25T20:19:42Z

Changes in this commit:

Fixed indentation of warning: parameter in ToolPackageRestorer.cs (line 103)
Improved existing test to use explicit versions to prevent breaking when _packageVersionA changes
Added test for prerelease-to-stable upgrade warning
Added test for stable-to-prerelease (no warning) behavior

Test Coverage:

Basic version upgrade warning
Prerelease to stable version warning
Stable to prerelease (no warning - prevents prerelease noise)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

marcpopMSFT · 2025-10-03T18:21:25Z

@baronfel I tested and this new code only runs if the current version of the tool is not found in the cache. That seems like an ok compromise to me as otherwise, we're hitting the network when theoretically we don't need to. However, it does mean that if you have the tool installed locally, you'll never get the notice.

marcpopMSFT · 2025-10-03T18:22:08Z

Tool 'dotnetsay' (version '2.1.1') was restored. Available commands: dotnetsay

A newer version of tool 'dotnetsay' is available (version '2.1.7'). Consider updating your manifest file.

baronfel · 2025-10-03T19:52:27Z

That's an interesting compromise for sure. I could see a dotnet tool check command in the future for more comprehensive checking.

marcpopMSFT · 2025-10-07T23:14:36Z

or a flag to dotnet tool restore which asks for the check. Either way, this change is reasonable and working as is so published for review.

Copilot

Pull Request Overview

This PR adds functionality to display warnings when newer versions of tools are available during dotnet tool restore operations. This helps users stay informed about tool updates and prevent compatibility issues with newer SDKs.

Key Changes:

Enhanced restore functionality to check for newer tool versions and display warnings
Added localized warning messages for the new version notification feature
Implemented comprehensive test coverage for the warning functionality

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
`ToolPackageRestorer.cs`	Added version checking logic and warning generation functionality
`ToolRestoreCommand.cs`	Enhanced result structure and display logic to show version warnings
`CliCommandStrings.resx`	Added the new localized message string for version warnings
Multiple `.xlf` files	Added localization entries for the new warning message
`ToolRestoreCommandTests.cs`	Added comprehensive test coverage for the warning functionality

KalleOlaviNiemitalo · 2025-10-09T20:44:45Z

This PR enhances dotnet tool restore to show warnings when newer versions of tools are available in the configured package sources.

I saw this and immediately worried about such a warning getting triggered in an automated build, being parsed by Jenkins and causing the build to be considered UNSTABLE.

It looks like the output is not actually formatted anything like "warning SDK0000: tool is not the latest available version" though, so it won't be parsed as a warning. Please call it a note, then.

marcpopMSFT · 2025-10-09T20:50:54Z

@KalleOlaviNiemitalo yeah, this in the bucket of CLI messages so shouldn't impact exit codes or builds. It can impact if someone is processing the output.

nagilson · 2025-12-10T17:40:13Z

+            // Use wildcard version range to get the latest version
+            var latestVersionRange = VersionRange.Parse("*");
+
+            var (latestVersion, _) = _toolPackageDownloader.GetNuGetVersion(


I'm pretty confident this won't add additional unexpected terminal output, so that's good.

nagilson · 2025-12-10T17:42:10Z

+            if (latestVersion != null && latestVersion > package.Version)
+            {
+                // If the current version is prerelease, show warning for any newer version
+                // If the current version is stable, only show warning for newer stable versions


Nice comments here 👍

nagilson · 2025-12-10T17:43:15Z

-
+
+                // Display warnings for successful restorations even in partial failure case
+                var warnings = toolRestoreResults.Where(r => r.IsSuccess && !string.IsNullOrEmpty(r.Warning)).Select(r => r.Warning);


Interesting, so we're returning it as a regular, (but yellow) line instead of a warning to prevent breaking changes. Seems good.

nagilson · 2025-12-10T17:45:45Z

+        [Fact]
+        public void WhenNewerVersionIsAvailableItShowsWarning()
+        {
+            var newerPackageVersion = NuGetVersion.Parse("2.1.4");


nit: we could probably add to the _packageVersionA to prevent updating that from breaking this test.

@copilot We also don't test the prerelease version behaviors, which seems significant enough that we should test to prevent regression.

Added in commit 1f3148a. The test now uses explicit versions to avoid breaking if _packageVersionA changes. Also added two tests for prerelease behaviors:

Prerelease to stable: Shows warning

Stable to prerelease: Does NOT show warning (prevents prerelease noise)

nagilson

Looks good - let's validate it adds the test and if it doesn't change anything else we should be good to go

Co-authored-by: nagilson <23152278+nagilson@users.noreply.github.com>

nagilson

Nicely done on the new test.

marcpopMSFT · 2026-01-28T18:35:37Z

/backport to release/10.0.3xx

github-actions · 2026-01-28T18:35:48Z

Started backporting to release/10.0.3xx (link to workflow run)

github-actions · 2026-01-28T18:36:21Z

@marcpopMSFT backporting to release/10.0.3xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

github-actions · 2026-01-28T18:39:53Z

Started backporting to release/10.0.3xx (link to workflow run)

github-actions · 2026-01-28T18:40:22Z

@marcpopMSFT backporting to release/10.0.3xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

baronfel · 2026-01-28T18:44:53Z

manual backport pr for 10.0.3xx is #52715

KalleOlaviNiemitalo · 2026-01-29T05:53:55Z

Does this show a warning if:

the manifest specifies version 1.0.0
the feed has versions 1.0.0, 1.1.0, and 1.2.0-rc.1

In this case, I think it should warn that the newer stable version 1.1.0 is available; but the implementation looks like it won't warn anything about versions, because the latest version 1.2.0-rc.1 is a prerelease but the specified version 1.0.0 is stable.

marcpopMSFT · 2026-01-29T19:12:06Z

@KalleOlaviNiemitalo see the code here: https://github.com/dotnet/sdk/blob/main/src/Cli/dotnet/Commands/Tool/Restore/ToolPackageRestorer.cs#L159

If the current version is a prerelease, it'll tell you if there's a newer prerelease. Otherwise, it won't tell you to update to a prerelease. Looking at the code, there is a slight gap in the scenario you mentioned where if there is a prerelease, we won't tell you about the latest stable version to upgrade to. Not sure how common that is but if you think it's worth improving the logic for, feel free to file an issue and we'll see if copilot can change the GetNuGetVersion call to account for that. Not something I'd prioritize as that seems more niche.

KalleOlaviNiemitalo · 2026-01-30T02:22:35Z

Linking back to #50991 for reference. This link was originally in the PR description but Copilot edited it out on December 10.

Initial plan

03e36f8

Copilot AI assigned Copilot and marcpopMSFT Sep 25, 2025

Copilot started work on behalf of marcpopMSFT September 25, 2025 20:19 View session

Add warning functionality for newer tool versions during restore

6bd5123

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] dotnet tool restore should provide warnings if new versions of tool is available~~ Add warnings for newer tool versions during dotnet tool restore Sep 25, 2025

Copilot AI requested a review from marcpopMSFT September 25, 2025 20:47

Copilot finished work on behalf of marcpopMSFT September 25, 2025 20:47

marcpopMSFT requested a review from baronfel October 7, 2025 23:13

marcpopMSFT marked this pull request as ready for review October 7, 2025 23:13

Copilot AI review requested due to automatic review settings October 7, 2025 23:13

Copilot AI reviewed Oct 7, 2025

View reviewed changes

marcpopMSFT requested a review from nagilson November 4, 2025 21:19

nagilson reviewed Dec 10, 2025

View reviewed changes

Comment thread src/Cli/dotnet/Commands/Tool/Restore/ToolPackageRestorer.cs

nagilson reviewed Dec 10, 2025

View reviewed changes

fix whitespace

065572a

Copilot started work on behalf of nagilson December 10, 2025 17:46 View session

nagilson approved these changes Dec 10, 2025

View reviewed changes

Address PR feedback: Fix indentation and add prerelease version tests

1f3148a

Co-authored-by: nagilson <23152278+nagilson@users.noreply.github.com>

Copilot AI requested a review from nagilson December 10, 2025 18:02

Copilot finished work on behalf of nagilson December 10, 2025 18:02

nagilson approved these changes Dec 10, 2025

View reviewed changes

marcpopMSFT enabled auto-merge December 10, 2025 18:18

This was referenced Dec 10, 2025

SSL Template Issue Causes Missing OSX Templates #51198

Open

Could Not Resolve SDK - repo testfx issue #51530

Open

marcpopMSFT merged commit 2e8fc8b into main Dec 17, 2025
29 checks passed

marcpopMSFT deleted the copilot/fix-43788e6e-9f45-41c4-a7b1-05113aa76e24 branch December 17, 2025 23:04

dotnet-maestro Bot mentioned this pull request Dec 18, 2025

[main] Source code updates from dotnet/sdk dotnet/dotnet#3940

Merged

baronfel mentioned this pull request Jan 28, 2026

[backport to release/10.0.3xx]Add warnings for newer tool versions during dotnet tool restore #52715

Merged



		// Display warnings for successful restorations even in partial failure case
		var warnings = toolRestoreResults.Where(r => r.IsSuccess && !string.IsNullOrEmpty(r.Warning)).Select(r => r.Warning);

Conversation

Copilot AI commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in this commit:

Test Coverage:

Uh oh!

marcpopMSFT commented Oct 3, 2025

Uh oh!

marcpopMSFT commented Oct 3, 2025

Uh oh!

baronfel commented Oct 3, 2025

Uh oh!

marcpopMSFT commented Oct 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KalleOlaviNiemitalo commented Oct 9, 2025

Uh oh!

marcpopMSFT commented Oct 9, 2025

Uh oh!

Uh oh!

nagilson Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

nagilson Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

nagilson Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

nagilson Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

nagilson left a comment

Choose a reason for hiding this comment

Uh oh!

nagilson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marcpopMSFT commented Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 28, 2026

Uh oh!

baronfel commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KalleOlaviNiemitalo commented Jan 29, 2026

Uh oh!

marcpopMSFT commented Jan 29, 2026

Uh oh!

KalleOlaviNiemitalo commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Copilot AI commented Sep 25, 2025 •

edited

Loading

baronfel commented Jan 28, 2026 •

edited

Loading