[draft] Implement ProcessFrameworkReferences in pure MSBuild#52396
Draft
baronfel wants to merge 14 commits intodotnet:mainfrom
Draft
[draft] Implement ProcessFrameworkReferences in pure MSBuild#52396baronfel wants to merge 14 commits intodotnet:mainfrom
baronfel wants to merge 14 commits intodotnet:mainfrom
Conversation
baronfel
force-pushed
the
factor-out-processframeworkreferences-into-separate-msbuild-steps
branch
from
665ceff to
f517c00
Compare
…ome correctness corner cases.
…for the TFM seem to be equivalent. Crossgen/IL/AOT next.
…ration is broken.
baronfel
force-pushed
the
factor-out-processframeworkreferences-into-separate-msbuild-steps
branch
from
f517c00 to
3392139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment to reimplement PFR in more MSBuild logic to help the debuggability of the Target. At this point I believe I have parity, so I kicked this off to get CI feedback. Both mechanisms are implemented, so a simple boolean property swaps between them for comparison.
This does all of the things that the current PFR does, and it fixes a bug where targeting packs and RID-specific runtime packs were downloaded for every KnownFrameworkReference that matched the current TFM, not just the FrameworkReference items that the project actually has.
This can also be faster than the current PFR - in my binlogs comparing the new version to the old, it's common to have the old PFR be ~50ms and the new ~5ms.