[wasm] Remove "UsingBlazorOrWasmSdk" condition from emscripten workload detection#52600
Merged
[wasm] Remove "UsingBlazorOrWasmSdk" condition from emscripten workload detection#52600
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Blazor/WebAssembly SDK condition from Emscripten workload detection logic, syncing with runtime changes that enable browser-wasm library mode without requiring the workload. This is a companion change to PR #52250 which made a similar update to the Mono.Toolchain manifest.
Changes:
- Simplified the
UsingBrowserRuntimeWorkloadcondition to only require the workload when AOT compilation is explicitly enabled, removing the check that forced workload usage for non-Blazor/WebAssembly SDK scenarios - Added a guard to prevent overriding previously set
UsingBrowserRuntimeWorkloadvalues
lewing
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelfContained=truefrom WorkloadManifest. We set it for WasmSDK in https://github.com/dotnet/sdk/blob/main/src/WasmSdk/Sdk/Sdk.props#L19 and there is no requirement to have it set just forRID=browser-wasmlib