[clr-ios] Add UseMonoRuntime and PublishReadyToRun to the for the build and publish telemetry#53263
[clr-ios] Add UseMonoRuntime and PublishReadyToRun to the for the build and publish telemetry#53263kotlarmilos wants to merge 2 commits intodotnet:mainfrom
UseMonoRuntime and PublishReadyToRun to the for the build and publish telemetry#53263Conversation
|
This PR has been labeled with
|
There was a problem hiding this comment.
Pull request overview
This PR extends the workload telemetry system for iOS/mobile targets to capture UseMonoRuntime and PublishReadyToRun properties in both publish and build scenarios. Previously, the WorkloadPublishProperties telemetry event (fired after Publish) lacked these two properties; now they are added there, and a new _WorkloadBuildTelemetry target is introduced that fires after Build to emit a separate WorkloadBuildProperties event with the same set of core properties (but without publish-only extras like BlazorWasm, WasmSDK, UsesMobileSDKOnly, UsesOtherMobileSDK, LibraryMode, StripILAfterAOT).
Changes:
UseMonoRuntimeandPublishReadyToRunadded to the existingWorkloadPublishProperties(publish telemetry)- New
_WorkloadBuildTelemetryMSBuild target added, firingAfterTargets="Build"to emit aWorkloadBuildPropertiestelemetry event with build-time properties - New
WorkloadBuildPropertiesTelemetryEventNameconstant registered inMSBuildLoggeras a pass-through event, with a corresponding unit test
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Workloads/Manifests/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadTelemetry.targets |
Adds UseMonoRuntime/PublishReadyToRun to publish telemetry; adds new _WorkloadBuildTelemetry target for build-time telemetry |
src/Cli/dotnet/Commands/MSBuild/MSBuildLogger.cs |
Registers new WorkloadBuildProperties event name as a pass-through telemetry event |
test/dotnet.Tests/CommandTests/MSBuild/GivenMSBuildLogger.cs |
Unit test verifying WorkloadBuildProperties telemetry passes through correctly with expected properties |
You can also share your feedback on Copilot code review. Take the survey.
|
UseMonoRuntime and PublishReadyToRun are already tracked in the |
|
You are right, I missed that. This PR adds more granular mobile telemetry info about mobile setup (R2R vs Interp vs JIT). Is there an overhead to emitting these additional events? |
|
There is mild overhead, but not enough to prevent adding new events of course. I see now that there was existing workload build data and this is expanding the existing pattern, so I'll shut up now :) |
If there is any missing telemetry, we could probably add it to the same place as done in https://github.com/dotnet/sdk/pull/50561/changes (it should already track most of the needed stuff). There should be a way to connect the |
|
@matouskozak yes, the events will have a shared |
Description
This PR adds
UseMonoRuntimeandPublishReadyToRunto the publish telemetry. It adds a_WorkloadBuildTelemetrytarget that is invokedAfterTargets=Buildwith the build properties.Fixes dotnet/runtime#124746