Quote arguments to [MSBuild]::MakeRelative#53446
Quote arguments to [MSBuild]::MakeRelative#53446marcpopMSFT merged 5 commits intodotnet:release/10.0.2xxfrom
Conversation
Fix dotnet#53385 by quoting file-path arguments so any commas within the paths do not leak into MSBuild's understanding of the arguments to the property function.
There was a problem hiding this comment.
Pull request overview
Fixes publish/build failures when Content item paths contain commas by ensuring MSBuild parses [MSBuild]::MakeRelative arguments correctly (addresses regression from #52275 / issue #53385).
Changes:
- Quote both arguments passed to
$([MSBuild]::MakeRelative(...))when computingContentTargetPathduring publish item collection.
This test verifies that Content items with commas in their filenames can be published without triggering MSB4186 due to the comma being interpreted as an argument separator.
|
@JanKrivanek @baronfel I copied the test from the other PR but looks like it was missing something. If y'all want to prep for tactics while I'm out, please do. If not, I'll get to it Monday. |
|
The errors were a test arrangement change, fixed that up and things seem to be ready to go for Tactics consideration. |
|
New test failed, will need to investigate. |
|
If it was meant for 10.0.202, then it's clearly not fixed. Otherwise, we cross our fingers for the next version. |
|
Not fixed in 10.0.203 either. This is becoming quite frustrating... |
Fix #53385 by quoting file-path arguments so any commas within the paths
do not leak into MSBuild's understanding of the arguments to the
property function.
Fixes #53385
Summary
Customers with
Contentitems that had commas in the filenames hit build/publish failures.Customer Impact
Build failures on update to 10.0.200.
Regression?
Yes, from #52275.
Testing
Privates tested against repro project from #53385 (comment).
Risk
Low -- quoting arguments following the pattern used elsewhere.