Skip crossgen for DotnetTools-unique assemblies to reduce SDK size#53659
Merged
MichaelSimons merged 1 commit intodotnet:mainfrom Apr 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR broadens the crossgen exclusion for Visual Basic Roslyn assemblies so all copies across the SDK layout remain IL-only, enabling DeduplicateAssembliesWithLinks to deduplicate them via symlinks and reducing overall layout size.
Changes:
- Removes the narrow Roslyn/bincore-only exclusion for
Microsoft.CodeAnalysis.VisualBasic.dll. - Adds global wildcard removals for
Microsoft.CodeAnalysis.VisualBasic*.dllfrom bothRoslynFilesandRemainingFilescrossgen item groups.
DotnetTools assemblies that don't exist elsewhere in the SDK layout gain little from crossgen since global tools are invoked infrequently. Crossgen'ing them also prevents DeduplicateAssembliesWithLinks from linking them to identical copies elsewhere, resulting in a net size increase. Add a FilterItemsByDuplicateHash MSBuild task that compares DotnetTools assemblies against the rest of the layout by content hash. Only assemblies that also exist outside DotnetTools are crossgen'd — these will be deduplicated regardless, so crossgen adds startup benefit without size cost. Assemblies unique to DotnetTools are left as IL-only. Also broaden the existing VB crossgen exclusion to cover all Microsoft.CodeAnalysis.VisualBasic*.dll across the entire layout, not just the copy in Roslyn/bincore.
MichaelSimons
force-pushed
the
fix/exclude-vb-from-crossgen
branch
from
70bf25a to
36a67cd
Compare
MichaelSimons
changed the title
MiYanni
approved these changes
Apr 2, 2026
Member
Author
|
/ba-g known intermitent failures in watch aspire and blazor web assembly tests. |
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #53266
Changes
FilterItemsByDuplicateHashMSBuild task (src/Tasks/sdk-tasks/FilterItemsByDuplicateHash.cs)DeduplicateAssembliesWithLinksviaFileHasherutility classCrossgen.targetsFilterItemsByDuplicateHashMicrosoft.CodeAnalysis.VisualBasic*.dll) to apply globally, not just toRoslyn/bincoreOn a linux-x64 dev build, this reduces the tarball by 23.6 MB