Skip to content

Fix reporting Hot Reload capabilities of WASM projects#53665

Merged
tmat merged 4 commits intodotnet:release/10.0.3xxfrom
tmat:FixWasmCapabilityLogging
Apr 15, 2026
Merged

Fix reporting Hot Reload capabilities of WASM projects#53665
tmat merged 4 commits intodotnet:release/10.0.3xxfrom
tmat:FixWasmCapabilityLogging

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Apr 1, 2026

No description provided.

Comment thread src/Dotnet.Watch/HotReloadClient/Web/WebAssemblyHotReloadClient.cs
@tmat tmat marked this pull request as ready for review April 1, 2026 23:52
@tmat tmat requested a review from a team as a code owner April 1, 2026 23:52
Copilot AI review requested due to automatic review settings April 1, 2026 23:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dotnet watch / Hot Reload logging and associated tests to correctly report WebAssembly (Blazor WASM) Hot Reload capabilities, including distinguishing between capabilities coming from the project vs. inferred defaults.

Changes:

  • Add a dedicated log event/message for “Project specifies capabilities” and update WASM hot reload client logging accordingly.
  • Update tests to cover capability reporting across target frameworks/package versions and align with updated browser-refresh logging messages.
  • Extend TestAsset.WithSource to support overriding target framework and package version property substitutions for test scenarios.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/TestAssets/TestProjects/WatchBlazorWasm/blazorwasm.csproj Removes an older SelfContained workaround from the WASM test asset.
test/Microsoft.NET.TestFramework/TestAsset.cs Enhances WithSource to allow overriding TFM and package version substitutions.
test/dotnet-watch.Tests/HotReload/RazorHotReloadTests.cs Updates WASM Hot Reload tests to validate capability reporting and updated messages.
test/dotnet-watch.Tests/Browser/BrowserTests.cs Updates expectations for the renamed browser-refresh middleware message descriptor.
src/Dotnet.Watch/Watch/UI/IReporter.cs Adds new message descriptor and renames browser-refresh message descriptor.
src/Dotnet.Watch/Watch/AppModels/WebApplicationAppModel.cs Updates logging to use the renamed browser-refresh middleware descriptor.
src/Dotnet.Watch/HotReloadClient/Web/WebAssemblyHotReloadClient.cs Adjusts WASM capability logging and introduces a new log event usage.
src/Dotnet.Watch/HotReloadClient/Logging/LoggingUtilities.cs Fixes a typo in the tuple element name returned from ParseCategoryName.
src/Dotnet.Watch/HotReloadClient/Logging/LogEvents.cs Adds new log events for WASM capability-source reporting.

Comment thread src/Dotnet.Watch/HotReloadClient/Logging/LogEvents.cs Outdated
Comment thread src/Dotnet.Watch/HotReloadClient/Web/WebAssemblyHotReloadClient.cs Outdated
Comment thread src/Dotnet.Watch/Watch/UI/IReporter.cs
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Apr 3, 2026

@DustinCampbell ptal

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Apr 13, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Apr 15, 2026

/ba-g Unrelated test issues:

All test failures in PR #53665 are already tracked:

  1. ✅ C++/CLI tests (8 failures) — Tracked by C++/CLI tests fail on VS 2026 Helix machines - MSB8020 v143 platform toolset not found #53789 (C++/CLI tests fail on VS 2026 Helix machines - MSB8020 v143 platform toolset not found #53789) — VS 2026 Helix
    machines missing v143 platform toolset
  • SourceLinkTests.Cpp
  • GivenThatWeWantToBuildACppCliProject.* (4 methods)
  • GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.* (3 methods)
  • GivenThatWeWantToPublishACppCliProject.When_referenced_by_csharp_project_it_publishes_and_runs
  1. ✅ It_publishes_the_project_with_a_refs_folder_and_correct_deps_file (net46) — Tracked by It_publishes_the_project_with_a_refs_folder_and_correct_deps_file test failure #53796
    (It_publishes_the_project_with_a_refs_folder_and_correct_deps_file test failure #53796) — mscorlib.dll vs .NETFramework/v4.6/m… string mismatch

@tmat tmat merged commit 80922e4 into dotnet:release/10.0.3xx Apr 15, 2026
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants