Fix builtin workload manifests to use preview feature band in SDK archives#53857
Merged
mthalman merged 1 commit intodotnet:mainfrom Apr 15, 2026
Merged
Fix builtin workload manifests to use preview feature band in SDK archives#53857mthalman merged 1 commit intodotnet:mainfrom
mthalman merged 1 commit intodotnet:mainfrom
Conversation
…hives For preview SDK builds, the builtin workload manifests (mono toolchain, emscripten) were being placed under sdk-manifests/11.0.100/ instead of sdk-manifests/11.0.100-preview.4/. This happened because the layout target used BuiltinWorkloadFeatureBand (always stable, e.g. 11.0.100) without appending the _workloadVersionSuffix (e.g. -preview.4). The _workloadVersionSuffix is already computed in Directory.Build.props and correctly used for package IDs. This change applies it to the manifest layout directory path as well.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes preview SDK archive layout so builtin workload manifests are placed under the preview feature-band directory (e.g., sdk-manifests/11.0.100-preview.4/) instead of the stable feature band directory.
Changes:
- Update workload manifest layout path to append the already-computed
_workloadVersionSuffixto$(BuiltinWorkloadFeatureBand)when building the target directory.
This was referenced Apr 14, 2026
Open
dsplaisted
approved these changes
Apr 15, 2026
Member
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
Note that as noted in the bug, fixing this will break side-by-side preview installations. You'll need to remove previous .NET SDK 11.0.100 previews or you won't get the right workload versions. We should make sure to note this in the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For preview SDK builds, the builtin workload manifests (mono toolchain, emscripten) were being placed under sdk-manifests/11.0.100/ instead of sdk-manifests/11.0.100-preview.4/. This happened because the layout target used BuiltinWorkloadFeatureBand (always stable, e.g. 11.0.100) without appending the _workloadVersionSuffix (e.g. -preview.4).
The _workloadVersionSuffix is already computed in Directory.Build.props and correctly used for package IDs. This change applies it to the manifest layout directory path as well.
Fixes #53234