CLI: Normalize bool option action invoking#53872
Merged
baronfel merged 6 commits intodotnet:mainfrom Apr 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR normalizes how boolean option actions are invoked in the dotnet CLI by ensuring they only run when the option was explicitly provided on the command line and evaluates to true.
Changes:
- Updates several option action classes to accept
Option<bool>and gate execution onparseResult.HasOption(...)and the option’s parsed boolean value. - Replaces the diagnostic option precedence check to use the action’s bound
Option(instead of hard-codingParser.RootCommand.DiagOption). - Adds the required
Microsoft.DotNet.Cli.CommandLineusing for theHasOptionextension.
baronfel
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: fc3ce47
Summary
From the OTel changes un-revert, it seems that I missed there is an extension method we made,
HasOption, that does the same check I was doing by-hand. It is in a different project,Microsoft.DotNet.Cli.CommandLine, which is why I missed it. I also realized that all the bool option actions should do this check anyway.This means:
DefaultValueFactorydefined that would change this behavior.The actual way to do all this better is to actually change these options to be defined as a new type of option; something that doesn't contain a backing
Argument(thus, no value type). Meaning, make something likeFlagOptionthat only cares if it was provided on the CLI or not. But that would be a bigger endeavor.