Add NativeAOT + satellite assembly integration test

[Copilot]

• Add NativeAot_app_publishes_with_app_and_package_satellite_assemblies test to GivenThatWeWantToPublishAnAotApp.cs
  • Custom Program.cs using ResourceManager + CultureInfo("fr") to verify French resource at runtime
  • App-defined Strings.resx (neutral fallback) and Strings.fr.resx (French) embedded resources
  • System.Spatial 5.8.3 package reference (ships de/es/fr/it/ja/ko/ru/zh-Hans/zh-Hant satellites)
  • SatelliteResourceLanguages=fr;de filter
  • PublishAot=true, UseCurrentRuntimeIdentifier=true, SelfContained=true
  • StripSymbols=true on non-Windows
  • Assert fr/{projectName}.resources.dll exists (app satellite)
  • Assert fr/System.Spatial.resources.dll and de/System.Spatial.resources.dll exist (package satellites)
  • Assert ja/System.Spatial.resources.dll does NOT exist (filtered)
  • Assert native image exists and is native
  • Run native exe and assert stdout contains "Bonjour"
  • Derive ResourceManager base name from projectName variable (use interpolated string) so the test stays self-consistent if projectName ever changes

Original prompt

The conversation is about investigating test coverage for satellite assemblies in the dotnet/sdk repository, specifically under the context of a branch named `sdk-satellite-fix`. User progressively asked: 1. Are there tests for publishing with satellite assemblies (app-defined + package reference)? 2. Any NativeAOT tests? 3. Add a single NativeAOT test covering both app-defined and package-reference satellites. 4. Can the test run the native image to verify resources work at runtime?

I identified existing tests, then added a new test to test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs named NativeAot_app_publishes_with_app_and_package_satellite_assemblies. In the final step, I enhanced it to run the produced native exe and assert runtime resource loading.

Key technical details:

• CreateHelloWorldTestProject helper creates a basic test project with a Program.cs that prints "Hello World"
• TestProject has EmbeddedResources dict (auto-written like SourceFiles); SDK default globs include **/*.resx as EmbeddedResource
• System.Spatial 5.8.3 ships satellites for de, es, fr, it, ja, ko, ru, zh-Hans, zh-Hant (per GivenThatWeWantToFilterSatelliteAssemblies)
• Existing runnable AOT test pattern uses /p:UseCurrentRuntimeIdentifier=true, records NETCoreSdkPortableRuntimeIdentifier, sets StripSymbols=true on non-Windows, and uses RunExeCommand
• Build verification via ./build.sh was attempted but aborted (long bootstrap); system dotnet alone is insufficient because repo tests depend on redist

Recent operations: edited the file twice. First edit added a basic file-existence test. Second (final) edit replaced it with a runnable version that customizes Program.cs to use ResourceManager + CultureInfo("fr") and runs the native exe asserting "Bonjour".

1. Conversation Overview: - Primary Objectives: - "are there tests for publishing with satellite assemblies (either defined by the app or from package references)?" - "any nativeaot tests?" - "Ah can we add a nativeaot test that has satellite assemblies? both satellites defined by the app and from package reference? a single test ideally." - "can the test run the native image to ensure it can process the resources? (do other tests run)?" - Session Context: Investigation of satellite-assembly test coverage in the dotnet/sdk repo (branch `sdk-satellite-fix`), culminating in authoring a new NativeAOT publish test that exercises both app-defined satellites and package-reference satellites, then upgrading it to run the native image. - User Intent Evolution: From discovery (what tests exist?) → gap identification (no AOT+satellite coverage) → implementation (add single covering test) → strengthen (execute native image to validate runtime resource resolution).

2. Technical Foundation:

   • Repo: /home/sven/src/sdk-satellite-fix (dotnet/sdk)
   • Test framework: xUnit via SdkTest base class; TestAssetsManager.CreateTestProject(TestProject); PublishCommand, RunExeCommand, GetValuesCommand
   • TestProject model: SourceFiles, EmbeddedResources (both dumped to disk; SDK default globs pick up .resx), PackageReferences, AdditionalProperties, RecordProperties
   • NativeAOT publishing: /p:PublishAot=true, /p:UseCurrentRuntimeIdentifier=true, /p:SelfContained=true, NETCoreSdkPortableRuntimeIdentifier property recording, StripSymbols=true on non-Windows, IsNativeImage() helper
   • Satellite filtering: SatelliteResourceLanguages MSBuild property
   • Reference NuGet: System.Spatial 5.8.3 (ships de/es/fr/it/ja/ko/ru/zh-Hans/zh-Hant satellites)

3. Codebase Status:

   • test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs:
     • Purpose: Primary NativeAOT publish test suite
     • Current State: Added new test method NativeAot_app_publishes_with_app_and_package_satellite_assemblies inserted just before the private helper CheckIlcVersions (around line 1061)
     • Key Code Segments: New [RequiresMSBuildVersionFact("17.0.0.32901")] test that:
       • Calls CreateHelloWorldTestProject(CurrentTargetFramework, "NativeAotAppWithSatellites", true)
       • Records NETCoreSdkPortableRuntimeIdentifier, sets PublishAot=true, conditionally StripSymbols=true on non-Windows
       • Sets SatelliteResourceLanguages=fr;de
       • Adds new TestPackageReference("System.Spatial", "5.8.3")
       • Overrides SourceFiles[$"{projectName}.cs"] with a Main that uses new ResourceManager("{projectName}.Strings", typeof(Test).Assembly).GetString("HelloWorld", CultureInfo.GetCultureInfo("fr")), prints value, returns 0 iff equals "Bonjour"
       • Adds EmbeddedResources["Strings.resx"] (value "Hello") and EmbeddedResources["Strings.fr.resx"] (value "Bonjour") using minimal resx content
       • Publishes with /p:UseCurrentRuntimeIdentifier=true /p:SelfContained=true
       • Gets rid from recorded properties,...

Created from Copilot CLI via the copilot delegate command.

[Copilot]

Pull request overview

Adds end-to-end test coverage in the publish test suite for NativeAOT publish scenarios involving satellite assemblies, ensuring both app-authored and package-provided satellites are produced and usable at runtime.

Changes:

• Add NativeAot_app_publishes_with_app_and_package_satellite_assemblies to validate satellite assembly publish output under PublishAot=true.
• Validate SatelliteResourceLanguages filtering for package satellites (presence for fr/de, absence for ja).
• Execute the produced native binary and assert the French resource value is resolved at runtime.

[sbomer]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Done in 981ab55. The source file assignment now uses an interpolated string ($@"...") with {projectName}.Strings so the ResourceManager base name stays in sync with the project name automatically.