RunFileTests: bring missing changes from 10.0.4xx#54087
Merged
jjonescz merged 2 commits intodotnet:mainfrom Apr 28, 2026
Merged
RunFileTests: bring missing changes from 10.0.4xx#54087jjonescz merged 2 commits intodotnet:mainfrom
jjonescz merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Brings in missed test coverage changes from 10.0.4xx, primarily expanding validation around file-based program directives (notably #:ref), warning behavior, and some output assertion tightening.
Changes:
- Added extensive new tests for
#:refdirective behavior (paths, errors, transitivity, cycles, feature flagging, and interactions with#:include). - Added tests and adjusted assertions around
dotnet runwarning/no-warning scenarios and missing shebang warning (CA2266). - Introduced a shared test helper to enable the experimental
#:refdirective viaDirectory.Build.props.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests_General.cs | Adds stdin #:ref test and expands dotnet run warning/no-warning coverage; tightens stdout/stderr assertions. |
| test/dotnet.Tests/CommandTests/Run/RunFileTests_Directives.cs | Adds comprehensive #:ref directive test suite; adjusts include-mapping test line numbers due to shebang insertion. |
| test/dotnet.Tests/CommandTests/Run/RunFileTests_CscOnlyAndApi.cs | Adds tests covering up-to-date / csc-only behavior with #:ref, VirtualProjectBuilder PRE lifetime regression tests, and a virtual PRE creation test. |
| test/dotnet.Tests/CommandTests/Run/RunFileTests_BuildOptions.cs | Adds missing-shebang CA2266 warning tests; removes some now-unneeded test setup noise. |
| test/dotnet.Tests/CommandTests/Run/RunFileTests_BuildCommands.cs | Removes trailing whitespace (no functional change). |
| test/dotnet.Tests/CommandTests/Run/RunFileTestBase.cs | Adds EnableRefDirective helper and binlog evaluation count helper support. |
| test/dotnet.Tests/CommandTests/Project/Convert/DotnetProjectConvertTests.cs | Adds conversion tests for #:ref (direct, transitive, collisions, item copy/delete, and conversion scoping). |
MiYanni
approved these changes
Apr 27, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes were missed during automatic flows, probably due to badly resolved merge conflicts.