Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Dotnet.Watch/HotReloadAgent.Host/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@
# IDE0240: Remove redundant nullable directive
# The directive needs to be included since all sources in a source package are considered generated code
# when referenced from a project via package reference.
dotnet_diagnostic.IDE0240.severity = none
dotnet_diagnostic.IDE0240.severity = none

# CA2007: This assembly runs inside the user's app process where a SynchronizationContext may be present.
# Missing ConfigureAwait(false) can cause deadlocks (e.g. iOS UIKitSynchronizationContext).
dotnet_diagnostic.CA2007.severity = error
4 changes: 2 additions & 2 deletions src/Dotnet.Watch/HotReloadAgent.Host/NamedPipeTransport.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ public override async ValueTask SendAsync(IResponse response, CancellationToken
}
}

await _pipeClient.WriteAsync((byte)response.Type, cancellationToken);
await response.WriteAsync(_pipeClient, cancellationToken);
await _pipeClient.WriteAsync((byte)response.Type, cancellationToken).ConfigureAwait(false);
await response.WriteAsync(_pipeClient, cancellationToken).ConfigureAwait(false);
}

public override ValueTask<RequestStream> ReceiveAsync(CancellationToken cancellationToken)
Expand Down
2 changes: 1 addition & 1 deletion src/Dotnet.Watch/HotReloadAgent.Host/StartupHook.cs
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ async Task SendAndForgetAsync()
{
try
{
await listener.SendResponseAsync(new HotReloadExceptionCreatedNotification(code, message), CancellationToken.None);
await listener.SendResponseAsync(new HotReloadExceptionCreatedNotification(code, message), CancellationToken.None).ConfigureAwait(false);
}
catch
{
Expand Down
Loading