[Proposal] Use Span-based methods to split strings in analyzers#54121
Open
Alex-Sob wants to merge 4 commits intodotnet:mainfrom
Open
[Proposal] Use Span-based methods to split strings in analyzers#54121Alex-Sob wants to merge 4 commits intodotnet:mainfrom
Alex-Sob wants to merge 4 commits intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In .NET 8+ there are
MemoryExtensions.Splitmethods to split strings that areSpan-based, but they are unavailable for analyzers since they targetnetstandard2.0. What about providing someSpan-based helpers that could be used in analyzers?Changes
Added
SpanExtensionsstatic class with these methods as simplified versions ofMemoryExtensions.Split:Replaced
string.Splitcalls in a few places with one of the methods above. This should not only avoid allocatingstring[]array in each case, but this also allows to reduce allocations further, for example, if it's needed to callTrimon string parts or slice those parts. So that parts can be "materialized" into astringonly if it's necessary, e.g. to pass to an API that takes astring.