Skip to content

Fix broken run-file test RefDirective_Duplicate #54147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjonescz wants to merge 1 commit into from
+3 −4
Closed

Fix broken run-file test RefDirective_Duplicate #54147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/dotnet.Tests/CommandTests/Run/RunFileTests_Directives.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,7 @@ public static class Greeter
}
""");

// Duplicate #:ref directives are allowed (MSBuild can handle that).
File.WriteAllText(filePath, """
Comment thread
jjonescz marked this conversation as resolved.
#:ref lib.cs
#:ref lib.cs
Expand All @@ -581,16 +582,15 @@ public static class Greeter
new DotnetCommand(Log, "run", relativeFilePath)
.WithWorkingDirectory(testInstance.Path)
.Execute()
.Should().Fail()
.And.HaveStdErrContaining(DirectiveError(filePath, 2, FileBasedProgramsResources.DuplicateDirective, "#:ref lib.cs"));
.Should().Pass()
.And.HaveStdOut("Hello!");

File.WriteAllText(filePath, """
#:ref lib.cs
#:ref ./lib.cs
Console.WriteLine(MyLib.Greeter.Greet());
""");

// https://github.com/dotnet/sdk/issues/51139: we should detect the duplicate ref
new DotnetCommand(Log, "run", relativeFilePath)
.WithWorkingDirectory(testInstance.Path)
.Execute()
Expand All @@ -603,7 +603,6 @@ public static class Greeter
Console.WriteLine(MyLib.Greeter.Greet());
""");

// https://github.com/dotnet/sdk/issues/51139: we should detect the duplicate ref
new DotnetCommand(Log, "run", relativeFilePath)
.WithWorkingDirectory(testInstance.Path)
.Execute()
Expand Down
Loading